components/timer/DEPS - Issue 641943002: components: Introduce AlarmTimer class and use it for GCM heartbeat

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/timer/DEPS

Issue 641943002: components: Introduce AlarmTimer class and use it for GCM heartbeat (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix gyp files Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 include_rules = [

	2 # This directory is shared with Chrome OS, which only links against

	3 # base/. We don't want any other dependencies to creep in.

	4 "+base",
	blundell 2014/10/22 13:46:24 Everything can depend on //base, so this shouldn't Everything can depend on //base, so this shouldn't be necessary.
	5 "-chrome",
	blundell 2014/10/22 13:46:24 This isn't necessary as no component can depend on This isn't necessary as no component can depend on //chrome (i.e., this dependency would never creep in).
	6 "+components/timer",
	blundell 2014/10/22 13:46:24 This shouldn't be necessary. This shouldn't be necessary. Chirantan Ekbote 2014/10/23 23:53:30 Done. Show quoted text On 2014/10/22 13:46:24, blundell wrote: > This shouldn't be necessary. Done.
	7 "-content",

	8 "-net",

	9 "-third_party",
	blundell 2014/10/22 13:46:24 You might want to look at the DEPS that are allowe You might want to look at the DEPS that are allowed in //src/DEPS to see if there are other things you want to disallow here. Chirantan Ekbote 2014/10/22 18:47:14 Acknowledged. Show quoted text On 2014/10/22 13:46:24, blundell wrote: > You might want to look at the DEPS that are allowed in //src/DEPS to see if > there are other things you want to disallow here. Acknowledged.
	10 ]

OLD	NEW

« components/OWNERS ('K') | « components/timer/BUILD.gn ('k') | components/timer/OWNERS » ('j') | components/timer/alarm_timer.h » ('J')