Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9456)

Unified Diff: chrome_frame/test/reliability/page_load_test.cc

Issue 64193003: Clean up PrefServiceBuilder (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix memory ownership bug in ProxyPolicyTest Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome_frame/test/reliability/page_load_test.cc
diff --git a/chrome_frame/test/reliability/page_load_test.cc b/chrome_frame/test/reliability/page_load_test.cc
index 666b967f1db06b8b86c1a0159ca92bbb0128e60a..f93898c4bdf2d21c8ffba47db304ef329fd52697 100644
--- a/chrome_frame/test/reliability/page_load_test.cc
+++ b/chrome_frame/test/reliability/page_load_test.cc
@@ -38,7 +38,7 @@
#include "base/strings/utf_string_conversions.h"
#include "base/test/test_file_util.h"
#include "base/time/time.h"
-#include "chrome/browser/prefs/pref_service_mock_builder.h"
+#include "chrome/browser/prefs/pref_service_mock_factory.h"
#include "chrome/common/automation_messages.h"
#include "chrome/common/chrome_constants.h"
#include "chrome/common/chrome_paths.h"
@@ -434,12 +434,12 @@ class PageLoadTest : public testing::Test {
PrefService* GetLocalState(PrefRegistry* registry) {
base::FilePath path;
chrome::GetChromeFrameUserDataDirectory(&path);
- PrefServiceMockBuilder builder;
- builder.WithUserFilePrefs(
+ PrefServiceMockFactory factory;
+ factory.SetUserPrefsFile(
path,
JsonPrefStore::GetTaskRunnerForFile(
path, content::BrowserThread::GetBlockingPool()));
- return builder.Create(registry);
+ return factory.Create(registry).release();
}
void GetStabilityMetrics(NavigationMetrics* metrics) {
« no previous file with comments | « chrome/test/base/testing_pref_service_syncable.h ('k') | components/autofill/core/browser/autofill_test_utils.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698