Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5136)

Unified Diff: chrome/browser/profiles/profile_impl.cc

Issue 64193003: Clean up PrefServiceBuilder (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix memory ownership bug in ProxyPolicyTest Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/profiles/profile_impl.cc
diff --git a/chrome/browser/profiles/profile_impl.cc b/chrome/browser/profiles/profile_impl.cc
index d9010a7ebfa1a7ca45657e62d4ef76a8035f7d77..ed45f9f2422db3afd4a55651009fc38ee02bd04b 100644
--- a/chrome/browser/profiles/profile_impl.cc
+++ b/chrome/browser/profiles/profile_impl.cc
@@ -447,7 +447,7 @@ ProfileImpl::ProfileImpl(
// will work here.
startup_metric_utils::ScopedSlowStartupUMA
scoped_timer("Startup.SlowStartupPreferenceLoading");
- prefs_.reset(chrome_prefs::CreateProfilePrefs(
+ prefs_ = chrome_prefs::CreateProfilePrefs(
GetPrefFilePath(),
sequenced_task_runner,
profile_policy_connector_->policy_service(),
@@ -455,7 +455,7 @@ ProfileImpl::ProfileImpl(
new ExtensionPrefStore(
ExtensionPrefValueMapFactory::GetForBrowserContext(this), false),
pref_registry_,
- async_prefs));
+ async_prefs).Pass();
// Register on BrowserContext.
user_prefs::UserPrefs::Set(this, prefs_.get());
}
« no previous file with comments | « chrome/browser/prefs/proxy_policy_unittest.cc ('k') | chrome/browser/ui/app_list/app_list_service_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698