Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1944)

Unified Diff: chrome/browser/net/ssl_config_service_manager_pref_unittest.cc

Issue 64193003: Clean up PrefServiceBuilder (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix memory ownership bug in ProxyPolicyTest Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/net/ssl_config_service_manager_pref_unittest.cc
diff --git a/chrome/browser/net/ssl_config_service_manager_pref_unittest.cc b/chrome/browser/net/ssl_config_service_manager_pref_unittest.cc
index d9d7767741ee48c81849f0c401d978aa9478a4ff..70b1175e381f91113f2d95f89bb9cc6fd2898a65 100644
--- a/chrome/browser/net/ssl_config_service_manager_pref_unittest.cc
+++ b/chrome/browser/net/ssl_config_service_manager_pref_unittest.cc
@@ -11,7 +11,7 @@
#include "base/prefs/testing_pref_store.h"
#include "base/values.h"
#include "chrome/browser/content_settings/host_content_settings_map.h"
-#include "chrome/browser/prefs/pref_service_mock_builder.h"
+#include "chrome/browser/prefs/pref_service_mock_factory.h"
#include "chrome/common/chrome_switches.h"
#include "chrome/common/content_settings.h"
#include "chrome/common/pref_names.h"
@@ -153,10 +153,10 @@ TEST_F(SSLConfigServiceManagerPrefTest, BadDisabledCipherSuites) {
TEST_F(SSLConfigServiceManagerPrefTest, NoCommandLinePrefs) {
scoped_refptr<TestingPrefStore> local_state_store(new TestingPrefStore());
- PrefServiceMockBuilder builder;
- builder.WithUserPrefs(local_state_store.get());
+ PrefServiceMockFactory factory;
+ factory.set_user_prefs(local_state_store);
scoped_refptr<PrefRegistrySimple> registry = new PrefRegistrySimple;
- scoped_ptr<PrefService> local_state(builder.Create(registry.get()));
+ scoped_ptr<PrefService> local_state(factory.Create(registry.get()));
SSLConfigServiceManager::RegisterPrefs(registry.get());
@@ -204,11 +204,11 @@ TEST_F(SSLConfigServiceManagerPrefTest, CommandLinePrefs) {
command_line.AppendSwitchASCII(switches::kSSLVersionMax, "ssl3");
command_line.AppendSwitch(switches::kEnableUnrestrictedSSL3Fallback);
- PrefServiceMockBuilder builder;
- builder.WithUserPrefs(local_state_store.get());
- builder.WithCommandLine(&command_line);
+ PrefServiceMockFactory factory;
+ factory.set_user_prefs(local_state_store);
+ factory.SetCommandLine(&command_line);
scoped_refptr<PrefRegistrySimple> registry = new PrefRegistrySimple;
- scoped_ptr<PrefService> local_state(builder.Create(registry.get()));
+ scoped_ptr<PrefService> local_state(factory.Create(registry.get()));
SSLConfigServiceManager::RegisterPrefs(registry.get());
« no previous file with comments | « chrome/browser/net/pref_proxy_config_tracker_impl_unittest.cc ('k') | chrome/browser/prefs/chrome_pref_service_factory.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698