Clean up PrefServiceBuilder

chrome/browser/prefs/chrome_pref_service_factory.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/prefs/chrome_pref_service_factory.h"
 
 #include "base/bind.h"
 #include "base/debug/trace_event.h"
 #include "base/file_util.h"
 #include "base/files/file_path.h"
 #include "base/metrics/histogram.h"
 #include "base/prefs/default_pref_store.h"
 #include "base/prefs/json_pref_store.h"
 #include "base/prefs/pref_notifier_impl.h"
 #include "base/prefs/pref_registry.h"
 #include "base/prefs/pref_service.h"
 #include "base/prefs/pref_value_store.h"
 #include "chrome/browser/browser_process.h"
 #include "chrome/browser/prefs/command_line_pref_store.h"
 #include "chrome/browser/prefs/pref_model_associator.h"
-#include "chrome/browser/prefs/pref_service_syncable_builder.h"
+#include "chrome/browser/prefs/pref_service_syncable.h"
+#include "chrome/browser/prefs/pref_service_syncable_factory.h"
 #include "chrome/browser/ui/profile_error_dialog.h"
 #include "components/user_prefs/pref_registry_syncable.h"
 #include "content/public/browser/browser_context.h"
 #include "content/public/browser/browser_thread.h"
 #include "grit/chromium_strings.h"
 #include "grit/generated_resources.h"
 
 #if defined(ENABLE_CONFIGURATION_POLICY)
 #include "chrome/browser/policy/browser_policy_connector.h"
 #include "chrome/browser/policy/configuration_policy_pref_store.h"
@@ skipping 33 matching lines @@
                               base::Bind(&ShowProfileErrorDialog, message_id));
     }
 #else
     // On ChromeOS error screen with message about broken local state
     // will be displayed.
 #endif
   }
 }
 
 void PrepareBuilder(
-    PrefServiceSyncableBuilder* builder,
+    PrefServiceSyncableFactory* factory,
     const base::FilePath& pref_filename,
     base::SequencedTaskRunner* pref_io_task_runner,
     policy::PolicyService* policy_service,
     ManagedUserSettingsService* managed_user_settings,
     const scoped_refptr<PrefStore>& extension_prefs,
     bool async) {
 #if defined(OS_LINUX)
   // We'd like to see what fraction of our users have the preferences
   // stored on a network file system, as we've had no end of troubles
   // with NFS/AFS.
   // TODO(evanm): remove this once we've collected state.
   file_util::FileSystemType fstype;
   if (file_util::GetFileSystemType(pref_filename.DirName(), &fstype)) {
     UMA_HISTOGRAM_ENUMERATION("PrefService.FileSystemType",
                               static_cast<int>(fstype),
                               file_util::FILE_SYSTEM_TYPE_COUNT);
   }
 #endif
 
 #if defined(ENABLE_CONFIGURATION_POLICY)
   using policy::ConfigurationPolicyPrefStore;
-  builder->WithManagedPrefs(new ConfigurationPolicyPrefStore(
-      policy_service,
-      g_browser_process->browser_policy_connector()->GetHandlerList(),
-      policy::POLICY_LEVEL_MANDATORY));
-  builder->WithRecommendedPrefs(new ConfigurationPolicyPrefStore(
-      policy_service,
-      g_browser_process->browser_policy_connector()->GetHandlerList(),
-      policy::POLICY_LEVEL_RECOMMENDED));
+  factory->set_managed_prefs(
+      make_scoped_refptr(new ConfigurationPolicyPrefStore(
+          policy_service,
+          g_browser_process->browser_policy_connector()->GetHandlerList(),
+          policy::POLICY_LEVEL_MANDATORY)));
+  factory->set_recommended_prefs(
+      make_scoped_refptr(new ConfigurationPolicyPrefStore(
+          policy_service,
+          g_browser_process->browser_policy_connector()->GetHandlerList(),
+          policy::POLICY_LEVEL_RECOMMENDED)));
 #endif  // ENABLE_CONFIGURATION_POLICY
 
 #if defined(ENABLE_MANAGED_USERS)
   if (managed_user_settings) {
-    builder->WithSupervisedUserPrefs(
-        new SupervisedUserPrefStore(managed_user_settings));
+    factory->set_supervised_user_prefs(
+        make_scoped_refptr(new SupervisedUserPrefStore(managed_user_settings)));
   }
 #endif
 
-  builder->WithAsync(async);
-  builder->WithExtensionPrefs(extension_prefs.get());
-  builder->WithCommandLinePrefs(
-      new CommandLinePrefStore(CommandLine::ForCurrentProcess()));
-  builder->WithReadErrorCallback(base::Bind(&HandleReadError));
-  builder->WithUserPrefs(new JsonPrefStore(pref_filename, pref_io_task_runner));
+  factory->set_async(async);
+  factory->set_extension_prefs(extension_prefs);
+  factory->set_command_line_prefs(
+      make_scoped_refptr(
+          new CommandLinePrefStore(CommandLine::ForCurrentProcess())));
+  factory->set_read_error_callback(base::Bind(&HandleReadError));
+  factory->set_user_prefs(
+      new JsonPrefStore(pref_filename, pref_io_task_runner));
 }
 
 }  // namespace
 
 namespace chrome_prefs {
 
-PrefService* CreateLocalState(
+scoped_ptr<PrefService> CreateLocalState(
     const base::FilePath& pref_filename,
     base::SequencedTaskRunner* pref_io_task_runner,
     policy::PolicyService* policy_service,
     const scoped_refptr<PrefRegistry>& pref_registry,
     bool async) {
-  PrefServiceSyncableBuilder builder;
-  PrepareBuilder(&builder,
+  PrefServiceSyncableFactory factory;
+  PrepareBuilder(&factory,
                  pref_filename,
                  pref_io_task_runner,
                  policy_service,
                  NULL,
                  NULL,
                  async);
-  return builder.Create(pref_registry.get());
+  return factory.Create(pref_registry.get());
 }
 
-PrefServiceSyncable* CreateProfilePrefs(
+scoped_ptr<PrefServiceSyncable> CreateProfilePrefs(
     const base::FilePath& pref_filename,
     base::SequencedTaskRunner* pref_io_task_runner,
     policy::PolicyService* policy_service,
     ManagedUserSettingsService* managed_user_settings,
     const scoped_refptr<PrefStore>& extension_prefs,
     const scoped_refptr<user_prefs::PrefRegistrySyncable>& pref_registry,
     bool async) {
   TRACE_EVENT0("browser", "chrome_prefs::CreateProfilePrefs");
-  PrefServiceSyncableBuilder builder;
-  PrepareBuilder(&builder,
+  PrefServiceSyncableFactory factory;
+  PrepareBuilder(&factory,
                  pref_filename,
                  pref_io_task_runner,
                  policy_service,
                  managed_user_settings,
                  extension_prefs,
                  async);
-  return builder.CreateSyncable(pref_registry.get());
+  return factory.CreateSyncable(pref_registry.get());
 }
 
 }  // namespace chrome_prefs