Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Side by Side Diff: base/prefs/pref_service.h

Issue 64193003: Clean up PrefServiceBuilder (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix memory ownership bug in ProxyPolicyTest Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « base/base.gyp ('k') | base/prefs/pref_service_builder.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // This provides a way to access the application's current preferences. 5 // This provides a way to access the application's current preferences.
6 6
7 // Chromium settings and storage represent user-selected preferences and 7 // Chromium settings and storage represent user-selected preferences and
8 // information and MUST not be extracted, overwritten or modified except 8 // information and MUST not be extracted, overwritten or modified except
9 // through Chromium defined APIs. 9 // through Chromium defined APIs.
10 10
(...skipping 120 matching lines...) Expand 10 before | Expand all | Expand 10 after
131 } 131 }
132 132
133 const std::string name_; 133 const std::string name_;
134 134
135 const base::Value::Type type_; 135 const base::Value::Type type_;
136 136
137 // Reference to the PrefService in which this pref was created. 137 // Reference to the PrefService in which this pref was created.
138 const PrefService* pref_service_; 138 const PrefService* pref_service_;
139 }; 139 };
140 140
141 // You may wish to use PrefServiceBuilder or one of its subclasses 141 // You may wish to use PrefServiceFactory or one of its subclasses
142 // for simplified construction. 142 // for simplified construction.
143 PrefService( 143 PrefService(
144 PrefNotifierImpl* pref_notifier, 144 PrefNotifierImpl* pref_notifier,
145 PrefValueStore* pref_value_store, 145 PrefValueStore* pref_value_store,
146 PersistentPrefStore* user_prefs, 146 PersistentPrefStore* user_prefs,
147 PrefRegistry* pref_registry, 147 PrefRegistry* pref_registry,
148 base::Callback<void(PersistentPrefStore::PrefReadError)> 148 base::Callback<void(PersistentPrefStore::PrefReadError)>
149 read_error_callback, 149 read_error_callback,
150 bool async); 150 bool async);
151 virtual ~PrefService(); 151 virtual ~PrefService();
(...skipping 199 matching lines...) Expand 10 before | Expand all | Expand 10 after
351 351
352 // Local cache of registered Preference objects. The pref_registry_ 352 // Local cache of registered Preference objects. The pref_registry_
353 // is authoritative with respect to what the types and default values 353 // is authoritative with respect to what the types and default values
354 // of registered preferences are. 354 // of registered preferences are.
355 mutable PreferenceMap prefs_map_; 355 mutable PreferenceMap prefs_map_;
356 356
357 DISALLOW_COPY_AND_ASSIGN(PrefService); 357 DISALLOW_COPY_AND_ASSIGN(PrefService);
358 }; 358 };
359 359
360 #endif // BASE_PREFS_PREF_SERVICE_H_ 360 #endif // BASE_PREFS_PREF_SERVICE_H_
OLDNEW
« no previous file with comments | « base/base.gyp ('k') | base/prefs/pref_service_builder.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698