Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(692)

Unified Diff: pkg/analyzer2dart/lib/src/modely.dart

Issue 641923003: Remove the need for functionSignature. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Updated cf. comments Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | sdk/lib/_internal/compiler/implementation/dart_backend/backend_ast_emitter.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analyzer2dart/lib/src/modely.dart
diff --git a/pkg/analyzer2dart/lib/src/modely.dart b/pkg/analyzer2dart/lib/src/modely.dart
index ecfcc73b0cfa358e1ae5f2b4ca3277c051db30cb..46c1b319e17260a44b10817823d418dd0b6acef1 100644
--- a/pkg/analyzer2dart/lib/src/modely.dart
+++ b/pkg/analyzer2dart/lib/src/modely.dart
@@ -350,44 +350,11 @@ class TopLevelFunctionElementY extends ElementY
implements dart2js.FunctionElement {
analyzer.FunctionElement get element => super.element;
- dart2js.FunctionSignature _functionSignature;
-
- // TODO(johnniwinther): Avoid the need for these.
- @override
- dart2js.FunctionSignature get functionSignature {
- if (_functionSignature == null) {
- util.LinkBuilder<dart2js.Element> parameterBuilder =
- new util.LinkBuilder<dart2js.Element>();
- List<dart2js.DartType> parameterTypes = <dart2js.DartType>[];
- element.parameters.forEach((analyzer.ParameterElement parameter) {
- if (parameter.parameterKind.isOptional) {
- unsupported('Optional parameter.');
- } else {
- dart2js.ParameterElement convertedParameter =
- converter.convertElement(parameter);
- parameterBuilder.addLast(convertedParameter);
- parameterTypes.add(convertedParameter.type);
- }
- });
- // TODO(johnniwinther): Convert parameter and return types.
- util.Link<dart2js.Element> parameters = parameterBuilder.toLink();
- _functionSignature = new modelx.FunctionSignatureX(
- parameters,
- const util.Link<dart2js.Element>(),
- parameterBuilder.length, 0, false,
- parameters.toList(),
- new dart2js.FunctionType.synthesized(
- converter.convertType(element.returnType),
- parameterTypes));
- }
- return _functionSignature;
- }
-
@override
- bool get hasFunctionSignature => true;
+ dart2js.ElementKind get kind => dart2js.ElementKind.FUNCTION;
@override
- dart2js.ElementKind get kind => dart2js.ElementKind.FUNCTION;
+ dart2js.FunctionType get type => converter.convertType(element.type);
TopLevelFunctionElementY(ElementConverter converter,
analyzer.FunctionElement element)
@@ -403,7 +370,10 @@ class TopLevelFunctionElementY extends ElementY
get memberContext => unsupported('memberContext');
@override
- dart2js.FunctionType get type => functionSignature.type;
+ get functionSignature => unsupported('functionSignature');
+
+ @override
+ bool get hasFunctionSignature => unsupported('hasFunctionSignature');
}
class ParameterElementY extends ElementY
@@ -418,10 +388,6 @@ class ParameterElementY extends ElementY
@override
dart2js.DartType get type => converter.convertType(element.type);
- // TODO(johnniwinther): Avoid the need for this.
- @override
- dart2js.FunctionSignature get functionSignature => null;
-
@override
bool get isLocal => true;
@@ -448,6 +414,9 @@ class ParameterElementY extends ElementY
@override
get memberContext => unsupported('memberContext');
+
+ @override
+ get functionSignature => unsupported('functionSignature');
}
class TypeDeclarationElementY extends ElementY
« no previous file with comments | « no previous file | sdk/lib/_internal/compiler/implementation/dart_backend/backend_ast_emitter.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698