Adding Athenas browser and unit tests which are required for running the tests on a buildbot

Adding Athenas browser and unit tests which are required for running the tests on a buildbot

BUG=410400
TEST=-

Committed: https://crrev.com/5b91bf70d132d213d78c02e433fadd342c4438f6
Cr-Commit-Position: refs/heads/master@{#299302}

[Mr4D (OOO till 08-26), 2014-10-08 22:30:56]

skuhne@chromium.org changed reviewers:
+ dnj@chromium.org

[Mr4D (OOO till 08-26), 2014-10-08 22:30:57]

Please have a look!

[dnj, 2014-10-08 22:43:47]

On 2014/10/08 22:30:57, Mr4D wrote:
> Please have a look!

You also want to add tests for the tryserver builders that you're adding.

This is a very small set of tests compared to the other testers. I'll defer to
you; just wanted to note this :)

Also, I'm not a Chromium committer (yet), so you'll need another reviewer.

[Mr4D (OOO till 08-26), 2014-10-09 13:59:31]

skuhne@chromium.org changed reviewers:
+ sky@chromium.org

[Mr4D (OOO till 08-26), 2014-10-09 13:59:32]

Added proper trybot configuration.

Added sky as reviewer. (Note: this is the addition to CL 639163002)

[sky, 2014-10-09 17:43:19]

Did you run these tests on an FYI bot for a while to make sure they aren't
flakey?

https://codereview.chromium.org/641903002/diff/20001/testing/buildbot/chromiu...
File testing/buildbot/chromium.chromiumos.json (right):

https://codereview.chromium.org/641903002/diff/20001/testing/buildbot/chromiu...
testing/buildbot/chromium.chromiumos.json:98: "browser_tests"
Can these be swarmed?

[dnj, 2014-10-09 17:47:36]

> Did you run these tests on an FYI bot for a while to make sure they aren't
> flakey?

This is for the first bot setup. My understanding is that adding them here
doesn't immediately cause them to be invoked - the CQ has to also be configured
to invoke the builders. The thought was: add them here, test the builders
manually and, if everything works out, then add them to the CQ.

[Mr4D (OOO till 08-26), 2014-10-09 19:45:14]

Please see again!

Regarding your question - see dnj's response.

Thanks!

https://codereview.chromium.org/641903002/diff/20001/testing/buildbot/chromiu...
File testing/buildbot/chromium.chromiumos.json (right):

https://codereview.chromium.org/641903002/diff/20001/testing/buildbot/chromiu...
testing/buildbot/chromium.chromiumos.json:98: "browser_tests"
Should be the same as chrome. Added.

[sky, 2014-10-10 02:47:21]

sky@chromium.org changed reviewers:
+ phajdan.jr@chromium.org

[sky, 2014-10-10 02:47:22]

Not sure there.
+Pawel

[Paweł Hajdan Jr., 2014-10-10 13:58:07]

Let's do trybot first, and main waterfall only when there is proper coverage.

[Mr4D (OOO till 08-26), 2014-10-10 20:21:40]

As the recipes I have set this up as an FYI bot now. Please have another look!

[Paweł Hajdan Jr., 2014-10-13 13:28:27]

LGTM

[Mr4D (OOO till 08-26), 2014-10-13 14:02:31]

The CQ bit was checked by skuhne@chromium.org

[commit-bot: I haz the power, 2014-10-13 14:03:49]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/641903002/140001

[commit-bot: I haz the power, 2014-10-13 14:32:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-10-13 14:32:57]

Try jobs failed on following builders:
  mac_gpu_retina_triggered_tests on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu_retina_tr...)

[Mr4D (OOO till 08-26), 2014-10-13 14:44:57]

The CQ bit was checked by skuhne@chromium.org

[commit-bot: I haz the power, 2014-10-13 14:45:49]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/641903002/140001

[commit-bot: I haz the power, 2014-10-13 15:13:46]

Committed patchset #4 (id:140001)

[commit-bot: I haz the power, 2014-10-13 15:14:35]

Patchset 4 (id:??) landed as
https://crrev.com/5b91bf70d132d213d78c02e433fadd342c4438f6
Cr-Commit-Position: refs/heads/master@{#299302}

[oshima, 2014-10-16 09:43:21]

oshima@chromium.org changed reviewers:
+ oshima@chromium.org

[oshima, 2014-10-16 09:43:22]

https://codereview.chromium.org/641903002/diff/140001/testing/buildbot/chromi...
File testing/buildbot/chromium_trybot.json (right):

https://codereview.chromium.org/641903002/diff/140001/testing/buildbot/chromi...
testing/buildbot/chromium_trybot.json:208: "chromium_configs":
["chromium_chromeos_athena"]
please do not remove athena_unittests from chromeos bots. They still need to run
athena_unittests.

[Mr4D (OOO till 08-26), 2014-10-16 14:52:56]

https://codereview.chromium.org/641903002/diff/140001/testing/buildbot/chromi...
File testing/buildbot/chromium_trybot.json (right):

https://codereview.chromium.org/641903002/diff/140001/testing/buildbot/chromi...
testing/buildbot/chromium_trybot.json:208: "chromium_configs":
["chromium_chromeos_athena"]
We get our own builder and unit tester. In fact - the missing CL will land
today.

[oshima, 2014-10-16 15:52:22]

https://codereview.chromium.org/641903002/diff/140001/testing/buildbot/chromi...
File testing/buildbot/chromium_trybot.json (right):

https://codereview.chromium.org/641903002/diff/140001/testing/buildbot/chromi...
testing/buildbot/chromium_trybot.json:208: "chromium_configs":
["chromium_chromeos_athena"]
On 2014/10/16 14:52:55, Mr4D wrote:
> We get our own builder and unit tester. In fact - the missing CL will land
> today.

We still need this for two reasons.
1) main waterfall runs this test.
2) athena_main and athena_unittests should build and pass without use_athena=1.