include/gpu/GrGpuResource.h - Issue 641813002: call derived ~ from GrIORef

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: include/gpu/GrGpuResource.h

Issue 641813002: call derived ~ from GrIORef (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: include/gpu/GrGpuResource.h

diff --git a/include/gpu/GrGpuResource.h b/include/gpu/GrGpuResource.h

index 666ab0d3b65ec8de0ce90063ce75e32a30099451..00a503510712e74901e3455dd69b3c7c138d5700 100644

--- a/include/gpu/GrGpuResource.h

+++ b/include/gpu/GrGpuResource.h

@@ -103,7 +103,8 @@ private:

void didUnref() const {

if (0 == fPendingReads && 0 == fPendingWrites) {

if (0 == fRefCnt) {

- SkDELETE(this);

+ // Must call derived destructor since this is not a virtual class.

+ SkDELETE(static_cast<const DERIVED*>(this));

} else if (1 == fRefCnt) {

// The one ref is the cache's

static_cast<const DERIVED*>(this)->notifyIsPurgable();

« no previous file with comments | « no previous file | no next file » | no next file with comments »