Issue 641763003: RELEASE_ASSERT if last resort fallback font cannot be loaded.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 641763003: RELEASE_ASSERT if last resort fallback font cannot be loaded. (Closed)

Created:
6 years, 2 months ago by jbroman

Modified:
6 years, 2 months ago

Reviewers:
eae

CC:
blink-reviews, jamesr, pdr+graphicswatchlist_chromium.org, jbroman, mkwst+moarreviews_chromium.org, danakj, Rik, Stephen Chennney, krit, rwlbuis

Base URL:
svn://svn.chromium.org/blink/trunk

Project:
blink

Visibility:
Public.

More Reviews

Description

RELEASE_ASSERT if last resort fallback font cannot be loaded. This will help confirm the suspicion that a number of ClusterFuzz reports from constructTextRun are a result of this failing. There's probably nothing useful that can be done with a font that lacks any font data anyhow. BUG=421370 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183470

Patch Set 1 #

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	Source/platform/fonts/FontFallbackList.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 7 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/641763003/1

6 years, 2 months ago (2014-10-09 15:17:29 UTC) #5

commit-bot: I haz the power

Committed patchset #1 (id:1) as 183470

6 years, 2 months ago (2014-10-09 15:20:51 UTC) #6

jbroman

6 years, 2 months ago (2014-10-16 13:49:22 UTC) #7

Message was sent while issue was closed.

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/659073002/ by jbroman@chromium.org.

The reason for reverting is: Reverting per request.
https://code.google.com/p/chromium/issues/detail?id=421370#c11.

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages