Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1125)

Issue 641743002: mojom: Allow mojoms to only run a subset of the bindings generators. (Closed)

Created:
6 years, 2 months ago by Elliot Glaysher
Modified:
5 years, 11 months ago
Reviewers:
jamesr, viettrungluu
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

mojom: Allow mojoms to only run a subset of the bindings generators. This adds gyp and gn configuration variables for bindings generating targets. This was split off from https://codereview.chromium.org/611633002/ which adds syntax to the cpp bindings generator and uses it in the clipboard implementation. This change will allow us to modify the bindings generators one by one. BUG=413863

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -4 lines) Patch
M mojo/public/tools/bindings/mojom.gni View 3 chunks +47 lines, -4 lines 0 comments Download
M mojo/public/tools/bindings/mojom_bindings_generator.gypi View 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Elliot Glaysher
6 years, 2 months ago (2014-10-08 18:00:23 UTC) #2
jamesr
Wait, why? This seems like it'll encourage us to add language-specific features to mojom which ...
6 years, 2 months ago (2014-10-08 18:21:37 UTC) #3
Elliot Glaysher
On 2014/10/08 18:21:37, jamesr wrote: > Wait, why? This seems like it'll encourage us to ...
6 years, 2 months ago (2014-10-08 19:03:07 UTC) #4
Elliot Glaysher
(Actually +trung this time.)
6 years, 2 months ago (2014-10-08 19:25:20 UTC) #6
viettrungluu
6 years, 2 months ago (2014-10-08 21:38:33 UTC) #7
On 2014/10/08 19:03:07, Elliot Glaysher wrote:
> On 2014/10/08 18:21:37, jamesr wrote:
> > Wait, why?  This seems like it'll encourage us to add language-specific
> features
> > to mojom which would be pretty bad.
> 
> This is a temporary situation, and I intend to revert this patch once I've
> updated all the language bindings with associative array support. This lets me
> land the c++ bindings, while still having some practical usage to test the
> bindings generator so that it doesn't regress. The alternatives to this that I
> see are: land the c++ bindings without any usage (which seems fragile), or
> submit a mega version of https://codereview.chromium.org/611633002/ which
> includes modifications to all bindings.
> 
> +vtl who thinks we should be able to restrict the set of generators in
general.

Restrict and/or specify non-default generators.

Currently, we invoke all generators, which seems like overkill, especially given
that some of the files generated may not be usable on a particular system.

There are also use-cases for more generators with partial feature support. E.g.,
I may want very low-level (C-ish) bindings, for use by the actual system
implementation. It'd be nice, of course, if such a bindings generator supported
everything right at the outset, but I would only need support for plain old data
(and not, e.g., transferring handles).

Powered by Google App Engine
This is Rietveld 408576698