Align HTMLAppletElement IDL with spec

Align HTMLAppletElement IDL with spec

http://whatwg.org/html#htmlappletelement

In addition to removing TreatNullAs=NullString, align with the spec by
making hspace/vspace unsigned long, and codebase/object URLs.

The tests for the updated properties pass in Firefox Nightly, IE11
Release Preview and Opera 12.16, with these exceptions:

IE11 returns "" after setting width/height to null and fails all of
the vspace/hspace reflection tests in ways not per spec.

Presto doesn't reflect object as a URL, but the framework didn't
notice that before the minor fix in nullTestElementAttribute.
Presto also fails the vspace/hspace set tests in ways not per spec.

BUG=316129, 310298
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=161545

[philipj_slow, 2013-11-07 10:48:40]

https://chromiumcodereview.appspot.com/64173002/diff/1/Source/core/html/HTMLA...
File Source/core/html/HTMLAppletElement.idl (right):

https://chromiumcodereview.appspot.com/64173002/diff/1/Source/core/html/HTMLA...
Source/core/html/HTMLAppletElement.idl:28: [Reflect, URL] attribute DOMString
codeBase;
Do I need to add PerWorldBindings, ActivityLogging=SetterForIsolatedWorlds as
well?

[philipj_slow, 2013-11-07 12:29:48]

https://chromiumcodereview.appspot.com/64173002/diff/1/Source/core/html/HTMLA...
File Source/core/html/HTMLAppletElement.idl (right):

https://chromiumcodereview.appspot.com/64173002/diff/1/Source/core/html/HTMLA...
Source/core/html/HTMLAppletElement.idl:28: [Reflect, URL] attribute DOMString
codeBase;
On 2013/11/07 10:48:40, philipj wrote:
> Do I need to add PerWorldBindings, ActivityLogging=SetterForIsolatedWorlds as
> well?

I've made it so.

[jochen (gone - plz use gerrit), 2013-11-07 13:47:48]

https://chromiumcodereview.appspot.com/64173002/diff/1/Source/core/html/HTMLA...
File Source/core/html/HTMLAppletElement.idl (right):

https://chromiumcodereview.appspot.com/64173002/diff/1/Source/core/html/HTMLA...
Source/core/html/HTMLAppletElement.idl:28: [Reflect, URL] attribute DOMString
codeBase;
On 2013/11/07 12:29:49, philipj wrote:
> On 2013/11/07 10:48:40, philipj wrote:
> > Do I need to add PerWorldBindings, ActivityLogging=SetterForIsolatedWorlds
as
> > well?
> 
> I've made it so.

I don't know. Kentaro?

[philipj_slow, 2013-11-07 13:52:24]

On 2013/11/07 13:47:48, jochen wrote:
>
https://chromiumcodereview.appspot.com/64173002/diff/1/Source/core/html/HTMLA...
> File Source/core/html/HTMLAppletElement.idl (right):
> 
>
https://chromiumcodereview.appspot.com/64173002/diff/1/Source/core/html/HTMLA...
> Source/core/html/HTMLAppletElement.idl:28: [Reflect, URL] attribute DOMString
> codeBase;
> On 2013/11/07 12:29:49, philipj wrote:
> > On 2013/11/07 10:48:40, philipj wrote:
> > > Do I need to add PerWorldBindings, ActivityLogging=SetterForIsolatedWorlds
> as
> > > well?
> > 
> > I've made it so.
> 
> I don't know. Kentaro?

For reference, here's the review and blink-dev thread that makes me think yes:

https://codereview.chromium.org/55313003/
https://groups.google.com/a/chromium.org/d/msg/blink-dev/a5QEzbgfh6w/qy2LyezS...

[haraken, 2013-11-07 14:49:44]

https://chromiumcodereview.appspot.com/64173002/diff/1/Source/core/html/HTMLA...
File Source/core/html/HTMLAppletElement.idl (right):

https://chromiumcodereview.appspot.com/64173002/diff/1/Source/core/html/HTMLA...
Source/core/html/HTMLAppletElement.idl:28: [Reflect, URL] attribute DOMString
codeBase;
On 2013/11/07 13:47:48, jochen wrote:
> On 2013/11/07 12:29:49, philipj wrote:
> > On 2013/11/07 10:48:40, philipj wrote:
> > > Do I need to add PerWorldBindings, ActivityLogging=SetterForIsolatedWorlds
> as
> > > well?
> > 
> > I've made it so.
> 
> I don't know. Kentaro?

pmarch, felt: It's up to you (though we are not much excited about adding more
logging as you know:-).

[haraken, 2013-11-07 14:50:21]

philipj: Either way, you can leave it as is in this CL.

[jochen (gone - plz use gerrit), 2013-11-07 15:19:31]

lgtm modulo what felt@ or somebody with more insight into this says

[felt, 2013-11-07 15:36:59]

On 2013/11/07 15:19:31, jochen wrote:
> lgtm modulo what felt@ or somebody with more insight into this says

I wouldn't mind having logging on these properties, but it is not necessary. It
sounds like haraken@ would prefer not to add more logging so I am OK with not
adding logging here.

[philipj_slow, 2013-11-07 15:41:19]

On 2013/11/07 15:36:59, felt wrote:
> On 2013/11/07 15:19:31, jochen wrote:
> > lgtm modulo what felt@ or somebody with more insight into this says
> 
> I wouldn't mind having logging on these properties, but it is not necessary.
It
> sounds like haraken@ would prefer not to add more logging so I am OK with not
> adding logging here.

OK, I've removed it again. Thanks all!

[commit-bot: I haz the power, 2013-11-07 15:41:47]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/philipj@opera.com/64173002/160001

[haraken, 2013-11-07 15:43:49]

On 2013/11/07 15:36:59, felt wrote:
> On 2013/11/07 15:19:31, jochen wrote:
> > lgtm modulo what felt@ or somebody with more insight into this says
> 
> I wouldn't mind having logging on these properties, but it is not necessary.
It
> sounds like haraken@ would prefer not to add more logging so I am OK with not
> adding logging here.

I don't object to adding the logging if it's necessary for your experiment, but
otherwise we might want to avoid it as we discussed in blink-dev.

Either way that's a separate issue, so LGTM for this CL. If you need to add
logging, let's do that in a separate CL.

[commit-bot: I haz the power, 2013-11-07 17:01:41]

Change committed as 161545