Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 641713002: Smarter representation selection for phis. (Closed)

Created:
6 years, 2 months ago by titzer
Modified:
6 years, 2 months ago
Reviewers:
Jarin
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Smarter representation selection for phis. R=jarin@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=24474

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -47 lines) Patch
M src/compiler/simplified-lowering.cc View 2 chunks +56 lines, -47 lines 2 comments Download

Messages

Total messages: 4 (0 generated)
titzer
6 years, 2 months ago (2014-10-08 15:05:31 UTC) #1
Jarin
lgtm. Nice! https://codereview.chromium.org/641713002/diff/1/src/compiler/simplified-lowering.cc File src/compiler/simplified-lowering.cc (right): https://codereview.chromium.org/641713002/diff/1/src/compiler/simplified-lowering.cc#newcode280 src/compiler/simplified-lowering.cc:280: MachineType prop = kMachNone; How about expanding ...
6 years, 2 months ago (2014-10-08 15:12:03 UTC) #2
titzer
Committed patchset #1 manually as 24474 (presubmit successful).
6 years, 2 months ago (2014-10-08 16:01:29 UTC) #3
titzer
6 years, 2 months ago (2014-10-15 11:51:49 UTC) #4
Message was sent while issue was closed.
https://codereview.chromium.org/641713002/diff/1/src/compiler/simplified-lowe...
File src/compiler/simplified-lowering.cc (right):

https://codereview.chromium.org/641713002/diff/1/src/compiler/simplified-lowe...
src/compiler/simplified-lowering.cc:280: MachineType prop = kMachNone;
On 2014/10/08 15:12:03, jarin wrote:
> How about expanding to {propagate}?

Done.

Powered by Google App Engine
This is Rietveld 408576698