Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(542)

Unified Diff: device/battery/battery.gyp

Issue 641703002: Rewrite the Android implementation of BatteryMonitor directly in Java. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@battery-status-api-to-mojo
Patch Set: Address Ben's comments, update GN build, polish. Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: device/battery/battery.gyp
diff --git a/device/battery/battery.gyp b/device/battery/battery.gyp
index 5c2a4c67e33afa214b8f527af4e6b393990c6296..aece311c73db0f9b8dd7ff01909d7b8407249733 100644
--- a/device/battery/battery.gyp
+++ b/device/battery/battery.gyp
@@ -35,12 +35,8 @@
'DEVICE_BATTERY_IMPLEMENTATION',
],
'sources': [
- 'android/battery_jni_registrar.cc',
- 'android/battery_jni_registrar.h',
'battery_monitor_impl.cc',
'battery_monitor_impl.h',
- 'battery_status_manager_android.cc',
- 'battery_status_manager_android.h',
'battery_status_manager_chromeos.cc',
'battery_status_manager_default.cc',
'battery_status_manager_linux.cc',
@@ -53,14 +49,6 @@
'battery_status_service.h',
],
'conditions': [
- ['OS == "android"', {
- 'dependencies': [
- 'device_battery_jni_headers',
- ],
- 'sources!': [
- 'battery_status_manager_default.cc',
- ],
- }],
['chromeos==1', {
'dependencies': [
'../../build/linux/system.gyp:dbus',
@@ -101,21 +89,12 @@
['OS == "android"', {
'targets': [
{
- 'target_name': 'device_battery_jni_headers',
- 'type': 'none',
- 'sources': [
- 'android/java/src/org/chromium/device/battery/BatteryStatusManager.java',
- ],
- 'variables': {
- 'jni_gen_package': 'device_battery',
- },
- 'includes': [ '../../build/jni_generator.gypi' ],
- },
- {
'target_name': 'device_battery_java',
'type': 'none',
'dependencies': [
'../../base/base.gyp:base',
+ '../../mojo/public/mojo_public.gyp:mojo_bindings_java',
+ 'device_battery_mojo_bindings',
],
'variables': {
'java_in_dir': '../../device/battery/android/java',

Powered by Google App Engine
This is Rietveld 408576698