Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(314)

Issue 641693008: Fix crash in ResolveLanguageListOnBlockingPool (Closed)

Created:
6 years, 2 months ago by spang
Modified:
6 years, 2 months ago
CC:
chromium-reviews, stevenjb+watch_chromium.org, jshin+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix crash in ResolveLanguageListOnBlockingPool Evalation order of arguments is undefined, which can result in NULL pointers passed to ResolveLanguageListOnBlockingPool. BUG=422002 TEST=build & run on link_freon Committed: https://crrev.com/054258874a2cdd1118081beee16c10c746f04529 Cr-Commit-Position: refs/heads/master@{#299091}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -4 lines) Patch
M chrome/browser/ui/webui/chromeos/login/l10n_util.cc View 1 chunk +8 lines, -4 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
spang
6 years, 2 months ago (2014-10-09 19:30:02 UTC) #2
spang
6 years, 2 months ago (2014-10-09 19:35:14 UTC) #4
Alexander Alekseev
lgtm You're right.
6 years, 2 months ago (2014-10-09 19:36:47 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/641693008/1
6 years, 2 months ago (2014-10-09 19:38:37 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/16731)
6 years, 2 months ago (2014-10-09 19:49:30 UTC) #10
Nikita (slow)
lgtm
6 years, 2 months ago (2014-10-10 11:29:13 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/641693008/1
6 years, 2 months ago (2014-10-10 11:30:38 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-10 11:34:07 UTC) #14
commit-bot: I haz the power
6 years, 2 months ago (2014-10-10 11:34:57 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/054258874a2cdd1118081beee16c10c746f04529
Cr-Commit-Position: refs/heads/master@{#299091}

Powered by Google App Engine
This is Rietveld 408576698