Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Issue 641693003: Updated recipes command to use chartjson (Closed)

Created:
6 years, 2 months ago by sullivan
Modified:
6 years, 2 months ago
Reviewers:
tonyg
CC:
chromium-reviews, telemetry+watch_chromium.org, ghost stip (do not use), qyearsley, dtu
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Updated recipes command to use chartjson This is from https://codereview.chromium.org/595793005/ BUG=420044 Committed: https://crrev.com/5ae725e82a80bb1f8d155b85ecc4361cfbf083c5 Cr-Commit-Position: refs/heads/master@{#298891}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M tools/telemetry/telemetry/test_runner.py View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 10 (2 generated)
sullivan
https://codereview.chromium.org/634933002/ has been live for a full day with no issues. This moves the --output-format=chartjson ...
6 years, 2 months ago (2014-10-08 16:57:03 UTC) #2
tonyg
lgtm After this lands, please just double check that we get a data point on ...
6 years, 2 months ago (2014-10-09 01:13:46 UTC) #3
chromium-reviews
I realized that the android recipes bots are calling build/android/test_runner.py to run telemetry instead of ...
6 years, 2 months ago (2014-10-09 14:09:58 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/641693003/1
6 years, 2 months ago (2014-10-09 14:12:19 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1) as 9642f5bbd2105b048262c4eeda0104e791724951
6 years, 2 months ago (2014-10-09 16:16:50 UTC) #7
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/5ae725e82a80bb1f8d155b85ecc4361cfbf083c5 Cr-Commit-Position: refs/heads/master@{#298891}
6 years, 2 months ago (2014-10-09 16:17:23 UTC) #8
chromium-reviews
Verified data points are being sent to perf dashboard on desktop. Example: http://build.chromium.org/p/chromium.perf/builders/Linux%20Perf%20%283%29/builds/4405/steps/blink_perf.dom/logs/stdio On Thu, ...
6 years, 2 months ago (2014-10-09 17:02:25 UTC) #9
sullivan
6 years, 2 months ago (2014-10-10 15:27:52 UTC) #10
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/646913004/ by sullivan@chromium.org.

The reason for reverting is: Broke android recipes; see crbug.com/422174.

Powered by Google App Engine
This is Rietveld 408576698