Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(535)

Issue 641633002: Add test for tag pushing in push-to-trunk script. (Closed)

Created:
6 years, 2 months ago by Michael Achenbach
Modified:
6 years, 2 months ago
Reviewers:
tandrii(chromium)
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Add test for tag pushing in push-to-trunk script. BUG=chromium:410721 LOG=n TEST=script_test.py TBR=tandrii@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=24468

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+119 lines, -0 lines) Patch
M tools/push-to-trunk/test_scripts.py View 1 chunk +119 lines, -0 lines 2 comments Download

Messages

Total messages: 4 (1 generated)
Michael Achenbach
PTAL https://codereview.chromium.org/641633002/diff/1/tools/push-to-trunk/test_scripts.py File tools/push-to-trunk/test_scripts.py (right): https://codereview.chromium.org/641633002/diff/1/tools/push-to-trunk/test_scripts.py#newcode845 tools/push-to-trunk/test_scripts.py:845: def testPushToTrunkForcedNewGit(self): This is a dirty c/p from ...
6 years, 2 months ago (2014-10-08 13:07:40 UTC) #2
Michael Achenbach
Committed patchset #1 (id:1) manually as 24468 (tree was closed).
6 years, 2 months ago (2014-10-08 13:36:39 UTC) #3
tandrii(chromium)
6 years, 2 months ago (2014-10-08 17:13:02 UTC) #4
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698