Issue 641633002: Add test for tag pushing in push-to-trunk script.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 641633002: Add test for tag pushing in push-to-trunk script. (Closed)

Created:
6 years, 2 months ago by Michael Achenbach

Modified:
6 years, 2 months ago

Reviewers:
tandrii(chromium)

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Project:
v8

Visibility:
Public.

Description

Add test for tag pushing in push-to-trunk script. BUG=chromium:410721 LOG=n TEST=script_test.py TBR=tandrii@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=24468

Patch Set 1 #

Total comments: 2

Created: 6 years, 2 months ago

		Unified diffs	Side-by-side diffs	Stats (+119 lines, -0 lines)
	M	tools/push-to-trunk/test_scripts.py	View	1 chunk	+119 lines, -0 lines	2 comments

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Michael Achenbach

PTAL https://codereview.chromium.org/641633002/diff/1/tools/push-to-trunk/test_scripts.py File tools/push-to-trunk/test_scripts.py (right): https://codereview.chromium.org/641633002/diff/1/tools/push-to-trunk/test_scripts.py#newcode845 tools/push-to-trunk/test_scripts.py:845: def testPushToTrunkForcedNewGit(self): This is a dirty c/p from ...

6 years, 2 months ago (2014-10-08 13:07:40 UTC) #2

Michael Achenbach

Committed patchset #1 (id:1) manually as 24468 (tree was closed).

6 years, 2 months ago (2014-10-08 13:36:39 UTC) #3

Message was sent while issue was closed.

lgtm

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages