Rename wholeSubtree to adjacent.

Rename wholeSubtree to adjacent.

Using subtree invalidation is a current consequence of adjacent
combinators. Using "adjacent" as a feature should be more understandable.

Also tried to make the code more readable for the combinator handling in
general.

R=chrishtr@chromium.org,esprehn@chromium.org

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183571

[Mike West, 2014-10-08 12:23:59]

mkwst@chromium.org changed reviewers:
+ mkwst@chromium.org

[Mike West, 2014-10-08 12:24:00]

Please wait for one of your chosen reviewers to sign-off on the renaming, as
they know this code much better than I do, but the cleanup LGTM. It really
improves the readability.

https://codereview.chromium.org/641583002/diff/1/Source/core/css/RuleFeature.cpp
File Source/core/css/RuleFeature.cpp (right):

https://codereview.chromium.org/641583002/diff/1/Source/core/css/RuleFeature....
Source/core/css/RuleFeature.cpp:273: return current->tagHistory();
This is a huge improvement in readability. Kudos.

https://codereview.chromium.org/641583002/diff/1/Source/core/css/RuleFeature....
Source/core/css/RuleFeature.cpp:324: features.adjacent =
current->isAdjacentSelector();
This is even better. :)

[chrishtr, 2014-10-08 16:23:09]

Rune: will try to get to this today. I am Chromium sheriff right now so things
will be slightly delayed.

[chrishtr, 2014-10-10 16:26:02]

https://codereview.chromium.org/641583002/diff/1/Source/core/css/RuleFeature.cpp
File Source/core/css/RuleFeature.cpp (right):

https://codereview.chromium.org/641583002/diff/1/Source/core/css/RuleFeature....
Source/core/css/RuleFeature.cpp:270: features.treeBoundaryCrossing = true;
Can be written as:

features.treeBundaryCrossing = current->isShadowSelector();

just like the below.

[rune, 2014-10-10 20:00:35]

https://codereview.chromium.org/641583002/diff/1/Source/core/css/RuleFeature.cpp
File Source/core/css/RuleFeature.cpp (right):

https://codereview.chromium.org/641583002/diff/1/Source/core/css/RuleFeature....
Source/core/css/RuleFeature.cpp:270: features.treeBoundaryCrossing = true;
On 2014/10/10 at 16:26:02, chrishtr wrote:
> Can be written as:
> 
> features.treeBundaryCrossing = current->isShadowSelector();
> 
> just like the below.

Done.

[chrishtr, 2014-10-10 20:57:41]

The CQ bit was checked by chrishtr@chromium.org

[chrishtr, 2014-10-10 20:57:47]

lgtm

[commit-bot: I haz the power, 2014-10-10 20:57:59]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/641583002/30001

[commit-bot: I haz the power, 2014-10-11 01:38:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-10-11 01:38:24]

Try jobs failed on following builders:
  win_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/31273)

[esprehn, 2014-10-11 04:32:56]

The CQ bit was checked by esprehn@chromium.org

[commit-bot: I haz the power, 2014-10-11 04:33:15]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/641583002/30001

[commit-bot: I haz the power, 2014-10-11 05:13:01]

Committed patchset #2 (id:30001) as 183571