Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3231)

Unified Diff: chrome/browser/metrics/chrome_browser_main_extra_parts_metrics_mac.h

Issue 641453003: Add metrics for the number of attached displays. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: ENUMERATION -> COUNTS_100 Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/metrics/chrome_browser_main_extra_parts_metrics_mac.h
diff --git a/chrome/browser/metrics/chrome_browser_main_extra_parts_metrics_mac.h b/chrome/browser/metrics/chrome_browser_main_extra_parts_metrics_mac.h
new file mode 100644
index 0000000000000000000000000000000000000000..52ad06de73eedc904841e4a7657b543a9a54afff
--- /dev/null
+++ b/chrome/browser/metrics/chrome_browser_main_extra_parts_metrics_mac.h
@@ -0,0 +1,34 @@
+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_METRICS_CHROME_BROWSER_MAIN_EXTRA_PARTS_METRICS_MAC_H_
+#define CHROME_BROWSER_METRICS_CHROME_BROWSER_MAIN_EXTRA_PARTS_METRICS_MAC_H_
+
+#include "base/macros.h"
+#include "ui/gfx/display_observer.h"
+
+// This class records OSX metrics at start up, and during the lifetime of the
+// application.
+class ChromeBrowserMainExtraPartsMetricsMac : public gfx::DisplayObserver {
+ public:
+ ChromeBrowserMainExtraPartsMetricsMac();
+ virtual ~ChromeBrowserMainExtraPartsMetricsMac() override;
+
+ private:
+ // DisplayObserver overrides.
+ virtual void OnDisplayAdded(const gfx::Display& new_display) override;
+ virtual void OnDisplayRemoved(const gfx::Display& old_display) override;
+ virtual void OnDisplayMetricsChanged(const gfx::Display& display,
+ uint32_t changed_metrics) override;
+
+ // If the number of displays has changed, emit a UMA metric.
+ void EmitDisplaysChangedMetric();
+
+ // A cached value for the number of displays.
+ int displayCount_;
Robert Sesek 2014/10/10 15:17:07 naming: display_count_
erikchen 2014/10/10 17:01:54 Done.
+
+ DISALLOW_COPY_AND_ASSIGN(ChromeBrowserMainExtraPartsMetricsMac);
+};
+
+#endif // CHROME_BROWSER_METRICS_CHROME_BROWSER_MAIN_EXTRA_PARTS_METRICS_MAC_H_

Powered by Google App Engine
This is Rietveld 408576698