Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1424)

Unified Diff: chrome/browser/metrics/chrome_browser_main_extra_parts_metrics.h

Issue 641453003: Add metrics for the number of attached displays. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Comments from isherman. Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/metrics/chrome_browser_main_extra_parts_metrics.h
diff --git a/chrome/browser/metrics/chrome_browser_main_extra_parts_metrics.h b/chrome/browser/metrics/chrome_browser_main_extra_parts_metrics.h
index 04f3f0e1f3008fa24599288113abd9565c1a82c0..54c7cabb91afb67d15ac1ae1dd7a7eb544f7c2d3 100644
--- a/chrome/browser/metrics/chrome_browser_main_extra_parts_metrics.h
+++ b/chrome/browser/metrics/chrome_browser_main_extra_parts_metrics.h
@@ -9,6 +9,7 @@
#include "base/compiler_specific.h"
#include "base/memory/scoped_ptr.h"
#include "chrome/browser/chrome_browser_main_extra_parts.h"
+#include "ui/gfx/display_observer.h"
class ChromeBrowserMainParts;
@@ -16,7 +17,8 @@ namespace chrome {
void AddMetricsExtraParts(ChromeBrowserMainParts* main_parts);
}
-class ChromeBrowserMainExtraPartsMetrics : public ChromeBrowserMainExtraParts {
+class ChromeBrowserMainExtraPartsMetrics : public ChromeBrowserMainExtraParts,
+ public gfx::DisplayObserver {
public:
ChromeBrowserMainExtraPartsMetrics();
virtual ~ChromeBrowserMainExtraPartsMetrics();
@@ -27,6 +29,18 @@ class ChromeBrowserMainExtraPartsMetrics : public ChromeBrowserMainExtraParts {
virtual void PostBrowserStart() override;
private:
+ // DisplayObserver overrides.
+ virtual void OnDisplayAdded(const gfx::Display& new_display) override;
+ virtual void OnDisplayRemoved(const gfx::Display& old_display) override;
+ virtual void OnDisplayMetricsChanged(const gfx::Display& display,
+ uint32_t changed_metrics) override;
+
+ // If the number of displays has changed, emit a UMA metric.
+ void EmitDisplaysChangedMetric();
+
+ // A cached value for the number of displays.
+ int display_count_;
+
DISALLOW_COPY_AND_ASSIGN(ChromeBrowserMainExtraPartsMetrics);
};

Powered by Google App Engine
This is Rietveld 408576698