[Password Generation] Add unittest to verify bugfix at crrev.com/44c5e4

[Password Generation] Add unittest to verify bugfix at crrev.com/44c5e4

Previous fix was submitted without tests to facilitate merging.

BUG=419288
Committed: https://crrev.com/9b77e9f16a4bbd4e13c39f8084c2846f933d4776
Cr-Commit-Position: refs/heads/master@{#299221}

[Garrett Casto, 2014-10-08 00:49:34]

gcasto@chromium.org changed reviewers:
+ isherman@chromium.org

[Garrett Casto, 2014-10-08 00:49:35]

I have address all the comments from when this was previously uploaded at
https://codereview.chromium.org/614313002/. Apologies for the mess before, I was
in a bit of a rush.

[Ilya Sherman, 2014-10-08 01:12:59]

LGTM % nits.  Thanks for cycling back to this :)

https://codereview.chromium.org/641453002/diff/20001/components/password_mana...
File components/password_manager/core/browser/password_form_manager_unittest.cc
(right):

https://codereview.chromium.org/641453002/diff/20001/components/password_mana...
components/password_manager/core/browser/password_form_manager_unittest.cc:80:
MockAutofillManager* GetMockAutofillManager() {
nit: Since this is a simple accessor, I'd name the method
"mock_autofill_manager()"

https://codereview.chromium.org/641453002/diff/20001/components/password_mana...
components/password_manager/core/browser/password_form_manager_unittest.cc:154:
PasswordFormManagerTest() : client_(NULL /*password_store*/){}
nit: Please revert this diff; I think it was correct before.

https://codereview.chromium.org/641453002/diff/20001/components/password_mana...
components/password_manager/core/browser/password_form_manager_unittest.cc:248:
scoped_refptr<NiceMock<MockPasswordStore> > mock_store_;
nit: As long as you're here, you can change the angle brackets from "> >" to
">>".

[Garrett Casto, 2014-10-08 18:36:36]

https://codereview.chromium.org/641453002/diff/20001/components/password_mana...
File components/password_manager/core/browser/password_form_manager_unittest.cc
(right):

https://codereview.chromium.org/641453002/diff/20001/components/password_mana...
components/password_manager/core/browser/password_form_manager_unittest.cc:80:
MockAutofillManager* GetMockAutofillManager() {
On 2014/10/08 01:12:59, Ilya Sherman wrote:
> nit: Since this is a simple accessor, I'd name the method
> "mock_autofill_manager()"

Updated GetMockDriver() while I was at it.

https://codereview.chromium.org/641453002/diff/20001/components/password_mana...
components/password_manager/core/browser/password_form_manager_unittest.cc:154:
PasswordFormManagerTest() : client_(NULL /*password_store*/){}
On 2014/10/08 01:12:59, Ilya Sherman wrote:
> nit: Please revert this diff; I think it was correct before.

Done.

https://codereview.chromium.org/641453002/diff/20001/components/password_mana...
components/password_manager/core/browser/password_form_manager_unittest.cc:248:
scoped_refptr<NiceMock<MockPasswordStore> > mock_store_;
On 2014/10/08 01:12:58, Ilya Sherman wrote:
> nit: As long as you're here, you can change the angle brackets from "> >" to
> ">>".

Done.

[Garrett Casto, 2014-10-10 23:15:58]

The CQ bit was checked by gcasto@chromium.org

[commit-bot: I haz the power, 2014-10-10 23:16:44]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/641453002/40001

[commit-bot: I haz the power, 2014-10-11 00:38:05]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2014-10-11 00:38:45]

Patchset 3 (id:??) landed as
https://crrev.com/9b77e9f16a4bbd4e13c39f8084c2846f933d4776
Cr-Commit-Position: refs/heads/master@{#299221}