Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(140)

Issue 641443002: Add unprefixed EME tests for LoadSession() (Closed)

Created:
6 years, 2 months ago by jrummell
Modified:
6 years, 2 months ago
CC:
chromium-reviews, posciak+watch_chromium.org, feature-media-reviews_chromium.org, wjia+watch_chromium.org, mcasas+watch_chromium.org, eme-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Add unprefixed EME tests for LoadSession() BUG=338830 TEST=new EME tests pass Committed: https://crrev.com/e850894b42be7e4fb5df75392ccb79e18ccffe01 Cr-Commit-Position: refs/heads/master@{#299960}

Patch Set 1 #

Total comments: 4

Patch Set 2 : add TODO (plus rebase) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -13 lines) Patch
M chrome/browser/media/encrypted_media_browsertest.cc View 1 2 chunks +38 lines, -0 lines 0 comments Download
M media/cdm/ppapi/external_clear_key/clear_key_cdm.cc View 2 chunks +7 lines, -0 lines 0 comments Download
M media/test/data/eme_player_js/player_utils.js View 1 1 chunk +10 lines, -13 lines 0 comments Download
M media/test/data/eme_player_js/test_config.js View 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
jrummell
PTAL. This CL will land after the blink and Chromium changes go in.
6 years, 2 months ago (2014-10-08 00:37:42 UTC) #2
sandersd (OOO until July 31)
lgtm
6 years, 2 months ago (2014-10-08 18:20:02 UTC) #3
ddorwin
LGTM % comment. https://codereview.chromium.org/641443002/diff/1/chrome/browser/media/encrypted_media_browsertest.cc File chrome/browser/media/encrypted_media_browsertest.cc (right): https://codereview.chromium.org/641443002/diff/1/chrome/browser/media/encrypted_media_browsertest.cc#newcode337 chrome/browser/media/encrypted_media_browsertest.cc:337: class ECKUnprefixedEncryptedMediaTest : public EncryptedMediaTestBase { ...
6 years, 2 months ago (2014-10-08 22:04:28 UTC) #4
jrummell
Thanks for the reviews. https://codereview.chromium.org/641443002/diff/1/chrome/browser/media/encrypted_media_browsertest.cc File chrome/browser/media/encrypted_media_browsertest.cc (right): https://codereview.chromium.org/641443002/diff/1/chrome/browser/media/encrypted_media_browsertest.cc#newcode337 chrome/browser/media/encrypted_media_browsertest.cc:337: class ECKUnprefixedEncryptedMediaTest : public EncryptedMediaTestBase ...
6 years, 2 months ago (2014-10-16 18:53:59 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/641443002/20001
6 years, 2 months ago (2014-10-16 18:54:36 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years, 2 months ago (2014-10-16 19:45:14 UTC) #8
commit-bot: I haz the power
6 years, 2 months ago (2014-10-16 19:48:12 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e850894b42be7e4fb5df75392ccb79e18ccffe01
Cr-Commit-Position: refs/heads/master@{#299960}

Powered by Google App Engine
This is Rietveld 408576698