Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 641373002: Introduce FeedbackVectorSlot type - better than int. (Closed)

Created:
6 years, 2 months ago by mvstanton
Modified:
6 years, 2 months ago
Reviewers:
Sven Panne
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Introduce FeedbackVectorSlot type - better than int. It's good to have typing around this value. R=svenpanne@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=24528

Patch Set 1 : Patch One. #

Patch Set 2 : Ports. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+219 lines, -194 lines) Patch
M src/arm/full-codegen-arm.cc View 1 14 chunks +16 lines, -16 lines 0 comments Download
M src/arm/lithium-codegen-arm.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/arm64/full-codegen-arm64.cc View 1 14 chunks +16 lines, -16 lines 0 comments Download
M src/arm64/lithium-codegen-arm64.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/ast.h View 21 chunks +47 lines, -56 lines 0 comments Download
M src/ast.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M src/compiler/ast-graph-builder.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/compiler/ast-graph-builder.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/compiler/js-generic-lowering.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M src/compiler/js-operator.h View 1 chunk +3 lines, -3 lines 0 comments Download
M src/compiler/js-operator.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M src/full-codegen.h View 1 chunk +4 lines, -1 line 0 comments Download
M src/full-codegen.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M src/hydrogen-instructions.h View 9 chunks +15 lines, -15 lines 0 comments Download
M src/ia32/full-codegen-ia32.cc View 1 14 chunks +16 lines, -16 lines 0 comments Download
M src/ia32/lithium-codegen-ia32.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/mips/full-codegen-mips.cc View 1 14 chunks +16 lines, -16 lines 0 comments Download
M src/mips/lithium-codegen-mips.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/type-info.h View 3 chunks +8 lines, -8 lines 0 comments Download
M src/type-info.cc View 7 chunks +13 lines, -10 lines 0 comments Download
M src/utils.h View 1 chunk +22 lines, -0 lines 0 comments Download
M src/x64/full-codegen-x64.cc View 1 14 chunks +16 lines, -16 lines 0 comments Download
M src/x64/lithium-codegen-x64.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M test/unittests/compiler/js-typed-lowering-unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
mvstanton
Hi Sven, here is the CL we discussed, thanks for the look! --Michael
6 years, 2 months ago (2014-10-10 11:57:33 UTC) #3
Sven Panne
lgtm
6 years, 2 months ago (2014-10-10 12:26:17 UTC) #4
mvstanton
6 years, 2 months ago (2014-10-10 13:22:32 UTC) #5
Message was sent while issue was closed. 
Committed patchset #2 (id:390001) manually as 24528 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698