Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 641353002: Blink GC plugin: Don't check conditions on invalid compilation units. (Closed)

Created:
6 years, 2 months ago by zerny-google
Modified:
6 years, 2 months ago
Reviewers:
haraken, hans
CC:
chromium-reviews, oilpan-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Blink GC plugin: Don't check conditions on invalid compilation units. BUG=421958, 334149 R=hans@chromium.org, haraken@chromium.org Committed: https://crrev.com/1ce6049f0a6f3a1bc989b5019564bb42cc47f1b4 Cr-Commit-Position: refs/heads/master@{#299084}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -0 lines) Patch
M tools/clang/blink_gc_plugin/BlinkGCPlugin.cpp View 1 chunk +4 lines, -0 lines 0 comments Download
A tools/clang/blink_gc_plugin/tests/crash_on_invalid.h View 1 chunk +26 lines, -0 lines 0 comments Download
A + tools/clang/blink_gc_plugin/tests/crash_on_invalid.cpp View 1 chunk +1 line, -1 line 0 comments Download
A + tools/clang/blink_gc_plugin/tests/crash_on_invalid.txt View 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
zerny-google
Hi Hans and Haraken, This CL should address crbug.com/421958 However, I can't get my local ...
6 years, 2 months ago (2014-10-10 08:42:00 UTC) #1
haraken
LGTM I'll land this.
6 years, 2 months ago (2014-10-10 08:55:02 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/641353002/1
6 years, 2 months ago (2014-10-10 08:55:43 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-10 09:32:55 UTC) #5
commit-bot: I haz the power
6 years, 2 months ago (2014-10-10 09:33:45 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1ce6049f0a6f3a1bc989b5019564bb42cc47f1b4
Cr-Commit-Position: refs/heads/master@{#299084}

Powered by Google App Engine
This is Rietveld 408576698