Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(910)

Issue 641343005: Share code between Factory::NewJSTypedArray and API (Closed)

Created:
6 years, 2 months ago by Dmitry Lomov (no reviews)
Modified:
6 years, 2 months ago
Reviewers:
Benedikt Meurer
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Share code between Factory::NewJSTypedArray and API R=bmeurer@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=24681

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+70 lines, -89 lines) Patch
M src/api.cc View 2 chunks +11 lines, -68 lines 0 comments Download
M src/factory.h View 1 chunk +3 lines, -1 line 0 comments Download
M src/factory.cc View 2 chunks +54 lines, -18 lines 0 comments Download
M test/unittests/compiler/js-typed-lowering-unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Dmitry Lomov (no reviews)
PTAL
6 years, 2 months ago (2014-10-17 07:54:31 UTC) #1
Benedikt Meurer
lgtm
6 years, 2 months ago (2014-10-17 08:02:13 UTC) #2
Dmitry Lomov (no reviews)
6 years, 2 months ago (2014-10-17 09:05:07 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 24681 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698