Issue 641343004: Don't use nonstandard %% dimension in unit tests

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 641343004: Don't use nonstandard %% dimension in unit tests (Closed)

Created:
6 years, 2 months ago by Timothy Loh

Modified:
6 years, 2 months ago

Reviewers:
dstockwell, alancutter (OOO until 2018)

CC:
dstockwell, darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-animation_chromium.org, blink-reviews-css, dglazkov+blink, ed+blinkwatch_opera.com, Eric Willigers, Mike Lawther (Google), rjwright, rwlbuis, rune+blink, shans, Steve Block, Timothy Loh

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Project:
blink

Visibility:
Public.

More Reviews

Description

Don't use nonstandard %% dimension in unit tests The current parser allows an arbitrary number of %s (e.g. left: 10%%%), but we shouldn't depend on it in our unit tests. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183857

Patch Set 1 #

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -5 lines)			Patch
	M	Source/core/animation/LengthStyleInterpolationTest.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	Source/core/css/CSSCalculationValueTest.cpp	View		1 chunk	+4 lines, -4 lines	0 comments	Download

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/641343004/1

6 years, 2 months ago (2014-10-17 03:24:14 UTC) #5

commit-bot: I haz the power

6 years, 2 months ago (2014-10-17 04:17:28 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) as 183857

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages