Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(327)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 6413036: Another big out-of-lining of test code. Hits a lot of gmock objects (Closed)

Created:
9 years, 10 months ago by Elliot Glaysher
Modified:
9 years, 7 months ago
Reviewers:
Lei Zhang, Nico
CC:
chromium-reviews, vrk (LEFT CHROMIUM), annacc, ajwong+watch_chromium.org, ncarter (slow), idana, dmaclach+watch_chromium.org, apatrick_chromium, darin-cc_chromium.org, brettw-cc_chromium.org, tim (not reviewing), ddorwin+watch_chromium.org, wez+watch_chromium.org, Raghu Simha, simonmorris+watch_chromium.org, sergeyu+watch_chromium.org, scherkus (not reviewing), jamiewalch+watch_chromium.org, hclam+watch_chromium.org, sjl, garykac+watch_chromium.org, acolwell GONE FROM CHROMIUM, lambroslambrou+watch_chromium.org, Paweł Hajdan Jr.
Visibility:
Public.

Description

Another big out-of-lining of test code. Hits a lot of gmock objects BUG=none TEST=compiles Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=74168

Patch Set 1 #

Total comments: 4

Patch Set 2 : lei comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+287 lines, -143 lines) Patch
M chrome/browser/policy/asynchronous_policy_loader_unittest.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/policy/asynchronous_policy_test_base.h View 1 2 chunks +9 lines, -16 lines 0 comments Download
A chrome/browser/policy/asynchronous_policy_test_base.cc View 1 1 chunk +31 lines, -0 lines 0 comments Download
M chrome/browser/policy/file_based_policy_provider_unittest.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/policy/mock_device_management_backend.h View 1 chunk +3 lines, -4 lines 0 comments Download
A chrome/browser/policy/mock_device_management_backend.cc View 1 chunk +13 lines, -0 lines 0 comments Download
M chrome/browser/sync/glue/model_associator_mock.h View 1 chunk +3 lines, -0 lines 0 comments Download
A chrome/browser/sync/glue/model_associator_mock.cc View 1 chunk +13 lines, -0 lines 0 comments Download
M chrome/browser/sync/profile_sync_service_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/sync/profile_sync_test_util.h View 3 chunks +20 lines, -68 lines 0 comments Download
A chrome/browser/sync/profile_sync_test_util.cc View 1 chunk +78 lines, -0 lines 0 comments Download
M chrome/browser/sync/syncable/syncable_mock.h View 2 chunks +4 lines, -6 lines 0 comments Download
A chrome/browser/sync/syncable/syncable_mock.cc View 1 chunk +16 lines, -0 lines 0 comments Download
M chrome/browser/sync/test_profile_sync_service.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/sync/test_profile_sync_service.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 11 chunks +11 lines, -3 lines 0 comments Download
M chrome/gpu/gpu_idirect3d9_mock_win.h View 1 chunk +2 lines, -1 line 0 comments Download
A chrome/gpu/gpu_idirect3d9_mock_win.cc View 1 chunk +9 lines, -0 lines 0 comments Download
M chrome/gpu/gpu_video_decoder_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/gpu_video_decoder_host_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/safe_browsing/mock_feature_extractor_clock.h View 1 chunk +2 lines, -2 lines 0 comments Download
A chrome/renderer/safe_browsing/mock_feature_extractor_clock.cc View 1 chunk +14 lines, -0 lines 0 comments Download
M chrome/test/live_sync/live_autofill_sync_test.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/test/sync/engine/test_directory_setter_upper.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/sync/engine/test_directory_setter_upper.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M media/media.gyp View 1 chunk +2 lines, -0 lines 0 comments Download
A + media/video/video_mock_objects.h View 2 chunks +4 lines, -4 lines 0 comments Download
A media/video/video_mock_objects.cc View 1 chunk +18 lines, -0 lines 0 comments Download
A + remoting/base/base_mock_objects.h View 3 chunks +5 lines, -4 lines 0 comments Download
A remoting/base/base_mock_objects.cc View 1 chunk +13 lines, -0 lines 0 comments Download
M remoting/base/codec_test.cc View 1 chunk +1 line, -1 line 0 comments Download
D remoting/client/mock_objects.h View 1 chunk +0 lines, -27 lines 0 comments Download
M remoting/host/screen_recorder_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M remoting/protocol/connection_to_client_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M remoting/remoting.gyp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Elliot Glaysher
http://codereview.chromium.org/6413036/diff/1/remoting/client/mock_objects.h File remoting/client/mock_objects.h (left): http://codereview.chromium.org/6413036/diff/1/remoting/client/mock_objects.h#oldcode6 remoting/client/mock_objects.h:6: #define REMOTING_CLIENT_MOCK_OBJECTS_H_ This file isn't included anywhere in the ...
9 years, 10 months ago (2011-02-08 02:25:42 UTC) #1
Lei Zhang
LGTM with comments below: http://codereview.chromium.org/6413036/diff/1/chrome/browser/policy/asynchronous_policy_test_base.h File chrome/browser/policy/asynchronous_policy_test_base.h (right): http://codereview.chromium.org/6413036/diff/1/chrome/browser/policy/asynchronous_policy_test_base.h#newcode12 chrome/browser/policy/asynchronous_policy_test_base.h:12: #include "chrome/browser/policy/mock_configuration_policy_store.h" Can you forward ...
9 years, 10 months ago (2011-02-08 03:56:13 UTC) #2
Elliot Glaysher
9 years, 10 months ago (2011-02-08 23:02:54 UTC) #3 
For reference

http://codereview.chromium.org/6413036/diff/1/chrome/test/live_sync/live_auto...
File chrome/test/live_sync/live_autofill_sync_test.h (right):

http://codereview.chromium.org/6413036/diff/1/chrome/test/live_sync/live_auto...
chrome/test/live_sync/live_autofill_sync_test.h:22: #include
"chrome/browser/webdata/web_database.h"
On 2011/02/08 03:56:13, Lei Zhang wrote:
> Why do we need this? I don't see WebDatabase used here. Does this belong in a
> .cc file?

It's used as part of an x->y()->z()->a() chain in here. It'll go away when I get
around to out-of-lining this file.

Powered by Google App Engine
This is Rietveld 408576698