Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 641283002: Separate the audio player app from Files.app

Created:
6 years, 2 months ago by yoshiki
Modified:
6 years, 2 months ago
Reviewers:
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, rginda+watch_chromium.org, mtomasz+watch_chromium.org, yoshiki+watch_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Separate the audio player app from Files.app BUG=

Patch Set 1 #

Patch Set 2 : Clean up #

Unified diffs Side-by-side diffs Delta from patch set Stats (+334 lines, -2409 lines) Patch
M chrome/browser/extensions/component_loader.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/extensions/component_loader.cc View 3 chunks +9 lines, -0 lines 0 comments Download
M chrome/test/data/extensions/api_test/file_manager_browsertest/file_manager/background.js View 1 chunk +9 lines, -0 lines 0 comments Download
M chrome/test/data/extensions/api_test/file_manager_browsertest/file_manager/open_audio_files.js View 12 chunks +44 lines, -38 lines 0 comments Download
A + ui/file_manager/audio_player/assets/100/bottom_base_center.png View Binary file 0 comments Download
A + ui/file_manager/audio_player/assets/100/bottom_base_left.png View Binary file 0 comments Download
A + ui/file_manager/audio_player/assets/100/bottom_base_right.png View Binary file 0 comments Download
A + ui/file_manager/audio_player/assets/100/player_button_next.png View Binary file 0 comments Download
A + ui/file_manager/audio_player/assets/100/player_button_pause.png View Binary file 0 comments Download
A + ui/file_manager/audio_player/assets/100/player_button_play.png View Binary file 0 comments Download
A + ui/file_manager/audio_player/assets/100/player_button_playlist.png View Binary file 0 comments Download
A + ui/file_manager/audio_player/assets/100/player_button_playlist_active.png View Binary file 0 comments Download
A + ui/file_manager/audio_player/assets/100/player_button_pressed.png View Binary file 0 comments Download
A + ui/file_manager/audio_player/assets/100/player_button_previous.png View Binary file 0 comments Download
A + ui/file_manager/audio_player/assets/100/player_button_repeat.png View Binary file 0 comments Download
A + ui/file_manager/audio_player/assets/100/player_button_repeat_active.png View Binary file 0 comments Download
A + ui/file_manager/audio_player/assets/100/player_button_shuffle.png View Binary file 0 comments Download
A + ui/file_manager/audio_player/assets/100/player_button_shuffle_active.png View Binary file 0 comments Download
A + ui/file_manager/audio_player/assets/100/player_button_volume.png View Binary file 0 comments Download
A + ui/file_manager/audio_player/assets/100/player_button_volume_active.png View Binary file 0 comments Download
A + ui/file_manager/audio_player/assets/100/player_timeline_base_center.png View Binary file 0 comments Download
A + ui/file_manager/audio_player/assets/100/player_timeline_base_left.png View Binary file 0 comments Download
A + ui/file_manager/audio_player/assets/100/player_timeline_base_right.png View Binary file 0 comments Download
A + ui/file_manager/audio_player/assets/100/player_timeline_handler.png View Binary file 0 comments Download
A + ui/file_manager/audio_player/assets/100/player_timeline_handler_pressed.png View Binary file 0 comments Download
A + ui/file_manager/audio_player/assets/100/player_timeline_played_center.png View Binary file 0 comments Download
A + ui/file_manager/audio_player/assets/100/player_timeline_played_left.png View Binary file 0 comments Download
A + ui/file_manager/audio_player/assets/100/player_timeline_played_right.png View Binary file 0 comments Download
A + ui/file_manager/audio_player/assets/100/player_volume_base_bottom.png View Binary file 0 comments Download
A + ui/file_manager/audio_player/assets/100/player_volume_base_center.png View Binary file 0 comments Download
A + ui/file_manager/audio_player/assets/100/player_volume_base_top.png View Binary file 0 comments Download
A + ui/file_manager/audio_player/assets/100/player_volume_level_bottom.png View Binary file 0 comments Download
A + ui/file_manager/audio_player/assets/100/player_volume_level_center.png View Binary file 0 comments Download
A + ui/file_manager/audio_player/assets/100/player_volume_level_top.png View Binary file 0 comments Download
A + ui/file_manager/audio_player/assets/200/bottom_base_center.png View Binary file 0 comments Download
A + ui/file_manager/audio_player/assets/200/bottom_base_left.png View Binary file 0 comments Download
A + ui/file_manager/audio_player/assets/200/bottom_base_right.png View Binary file 0 comments Download
A + ui/file_manager/audio_player/assets/200/player_button_next.png View Binary file 0 comments Download
A + ui/file_manager/audio_player/assets/200/player_button_pause.png View Binary file 0 comments Download
A + ui/file_manager/audio_player/assets/200/player_button_play.png View Binary file 0 comments Download
A + ui/file_manager/audio_player/assets/200/player_button_playlist.png View Binary file 0 comments Download
A + ui/file_manager/audio_player/assets/200/player_button_playlist_active.png View Binary file 0 comments Download
A + ui/file_manager/audio_player/assets/200/player_button_pressed.png View Binary file 0 comments Download
A + ui/file_manager/audio_player/assets/200/player_button_previous.png View Binary file 0 comments Download
A + ui/file_manager/audio_player/assets/200/player_button_repeat.png View Binary file 0 comments Download
A + ui/file_manager/audio_player/assets/200/player_button_repeat_active.png View Binary file 0 comments Download
A + ui/file_manager/audio_player/assets/200/player_button_shuffle.png View Binary file 0 comments Download
A + ui/file_manager/audio_player/assets/200/player_button_shuffle_active.png View Binary file 0 comments Download
A + ui/file_manager/audio_player/assets/200/player_button_volume.png View Binary file 0 comments Download
A + ui/file_manager/audio_player/assets/200/player_button_volume_active.png View Binary file 0 comments Download
A + ui/file_manager/audio_player/assets/200/player_timeline_base_center.png View Binary file 0 comments Download
A + ui/file_manager/audio_player/assets/200/player_timeline_base_left.png View Binary file 0 comments Download
A + ui/file_manager/audio_player/assets/200/player_timeline_base_right.png View Binary file 0 comments Download
A + ui/file_manager/audio_player/assets/200/player_timeline_handler.png View Binary file 0 comments Download
A + ui/file_manager/audio_player/assets/200/player_timeline_handler_pressed.png View Binary file 0 comments Download
A + ui/file_manager/audio_player/assets/200/player_timeline_played_center.png View Binary file 0 comments Download
A + ui/file_manager/audio_player/assets/200/player_timeline_played_left.png View Binary file 0 comments Download
A + ui/file_manager/audio_player/assets/200/player_timeline_played_right.png View Binary file 0 comments Download
A + ui/file_manager/audio_player/assets/200/player_volume_base_bottom.png View Binary file 0 comments Download
A + ui/file_manager/audio_player/assets/200/player_volume_base_center.png View Binary file 0 comments Download
A + ui/file_manager/audio_player/assets/200/player_volume_base_top.png View Binary file 0 comments Download
A + ui/file_manager/audio_player/assets/200/player_volume_level_bottom.png View Binary file 0 comments Download
A + ui/file_manager/audio_player/assets/200/player_volume_level_center.png View Binary file 0 comments Download
A + ui/file_manager/audio_player/assets/200/player_volume_level_top.png View Binary file 0 comments Download
A + ui/file_manager/audio_player/audio_player.html View 4 chunks +22 lines, -25 lines 0 comments Download
A + ui/file_manager/audio_player/css/audio_player.css View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ui/file_manager/audio_player/elements/audio_player.css View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ui/file_manager/audio_player/elements/audio_player.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ui/file_manager/audio_player/elements/control_panel.css View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ui/file_manager/audio_player/elements/control_panel.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ui/file_manager/audio_player/elements/track_list.css View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ui/file_manager/audio_player/elements/track_list.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ui/file_manager/audio_player/elements/volume_controller.css View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ui/file_manager/audio_player/elements/volume_controller.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ui/file_manager/audio_player/icons/audio-player-128.png View Binary file 0 comments Download
A + ui/file_manager/audio_player/icons/audio-player-256.png View Binary file 0 comments Download
A + ui/file_manager/audio_player/icons/audio-player-32.png View Binary file 0 comments Download
A + ui/file_manager/audio_player/icons/audio-player-48.png View Binary file 0 comments Download
A + ui/file_manager/audio_player/icons/audio-player-64.png View Binary file 0 comments Download
A + ui/file_manager/audio_player/icons/audio-player-96.png View Binary file 0 comments Download
A + ui/file_manager/audio_player/icons/audio-player-favicon-16.png View Binary file 0 comments Download
A + ui/file_manager/audio_player/icons/audio-player-favicon-32.png View Binary file 0 comments Download
A + ui/file_manager/audio_player/js/audio_player.js View 1 chunk +7 lines, -0 lines 0 comments Download
A + ui/file_manager/audio_player/js/audio_player_model.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A ui/file_manager/audio_player/js/audio_player_scripts.js View 1 chunk +46 lines, -0 lines 0 comments Download
A ui/file_manager/audio_player/js/background.js View 1 1 chunk +153 lines, -0 lines 0 comments Download
A + ui/file_manager/audio_player/js/metadata_worker.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ui/file_manager/audio_player/manifest.json View 1 3 chunks +23 lines, -42 lines 0 comments Download
D ui/file_manager/file_manager/audio_player/assets/100/bottom_base_center.png View Binary file 0 comments Download
D ui/file_manager/file_manager/audio_player/assets/100/bottom_base_left.png View Binary file 0 comments Download
D ui/file_manager/file_manager/audio_player/assets/100/bottom_base_right.png View Binary file 0 comments Download
D ui/file_manager/file_manager/audio_player/assets/100/player_button_next.png View Binary file 0 comments Download
D ui/file_manager/file_manager/audio_player/assets/100/player_button_pause.png View Binary file 0 comments Download
D ui/file_manager/file_manager/audio_player/assets/100/player_button_play.png View Binary file 0 comments Download
D ui/file_manager/file_manager/audio_player/assets/100/player_button_playlist.png View Binary file 0 comments Download
D ui/file_manager/file_manager/audio_player/assets/100/player_button_playlist_active.png View Binary file 0 comments Download
D ui/file_manager/file_manager/audio_player/assets/100/player_button_pressed.png View Binary file 0 comments Download
D ui/file_manager/file_manager/audio_player/assets/100/player_button_previous.png View Binary file 0 comments Download
D ui/file_manager/file_manager/audio_player/assets/100/player_button_repeat.png View Binary file 0 comments Download
D ui/file_manager/file_manager/audio_player/assets/100/player_button_repeat_active.png View Binary file 0 comments Download
D ui/file_manager/file_manager/audio_player/assets/100/player_button_shuffle.png View Binary file 0 comments Download
D ui/file_manager/file_manager/audio_player/assets/100/player_button_shuffle_active.png View Binary file 0 comments Download
D ui/file_manager/file_manager/audio_player/assets/100/player_button_volume.png View Binary file 0 comments Download
D ui/file_manager/file_manager/audio_player/assets/100/player_button_volume_active.png View Binary file 0 comments Download
D ui/file_manager/file_manager/audio_player/assets/100/player_timeline_base_center.png View Binary file 0 comments Download
D ui/file_manager/file_manager/audio_player/assets/100/player_timeline_base_left.png View Binary file 0 comments Download
D ui/file_manager/file_manager/audio_player/assets/100/player_timeline_base_right.png View Binary file 0 comments Download
D ui/file_manager/file_manager/audio_player/assets/100/player_timeline_handler.png View Binary file 0 comments Download
D ui/file_manager/file_manager/audio_player/assets/100/player_timeline_handler_pressed.png View Binary file 0 comments Download
D ui/file_manager/file_manager/audio_player/assets/100/player_timeline_played_center.png View Binary file 0 comments Download
D ui/file_manager/file_manager/audio_player/assets/100/player_timeline_played_left.png View Binary file 0 comments Download
D ui/file_manager/file_manager/audio_player/assets/100/player_timeline_played_right.png View Binary file 0 comments Download
D ui/file_manager/file_manager/audio_player/assets/100/player_volume_base_bottom.png View Binary file 0 comments Download
D ui/file_manager/file_manager/audio_player/assets/100/player_volume_base_center.png View Binary file 0 comments Download
D ui/file_manager/file_manager/audio_player/assets/100/player_volume_base_top.png View Binary file 0 comments Download
D ui/file_manager/file_manager/audio_player/assets/100/player_volume_level_bottom.png View Binary file 0 comments Download
D ui/file_manager/file_manager/audio_player/assets/100/player_volume_level_center.png View Binary file 0 comments Download
D ui/file_manager/file_manager/audio_player/assets/100/player_volume_level_top.png View Binary file 0 comments Download
D ui/file_manager/file_manager/audio_player/assets/200/bottom_base_center.png View Binary file 0 comments Download
D ui/file_manager/file_manager/audio_player/assets/200/bottom_base_left.png View Binary file 0 comments Download
D ui/file_manager/file_manager/audio_player/assets/200/bottom_base_right.png View Binary file 0 comments Download
D ui/file_manager/file_manager/audio_player/assets/200/player_button_next.png View Binary file 0 comments Download
D ui/file_manager/file_manager/audio_player/assets/200/player_button_pause.png View Binary file 0 comments Download
D ui/file_manager/file_manager/audio_player/assets/200/player_button_play.png View Binary file 0 comments Download
D ui/file_manager/file_manager/audio_player/assets/200/player_button_playlist.png View Binary file 0 comments Download
D ui/file_manager/file_manager/audio_player/assets/200/player_button_playlist_active.png View Binary file 0 comments Download
D ui/file_manager/file_manager/audio_player/assets/200/player_button_pressed.png View Binary file 0 comments Download
D ui/file_manager/file_manager/audio_player/assets/200/player_button_previous.png View Binary file 0 comments Download
D ui/file_manager/file_manager/audio_player/assets/200/player_button_repeat.png View Binary file 0 comments Download
D ui/file_manager/file_manager/audio_player/assets/200/player_button_repeat_active.png View Binary file 0 comments Download
D ui/file_manager/file_manager/audio_player/assets/200/player_button_shuffle.png View Binary file 0 comments Download
D ui/file_manager/file_manager/audio_player/assets/200/player_button_shuffle_active.png View Binary file 0 comments Download
D ui/file_manager/file_manager/audio_player/assets/200/player_button_volume.png View Binary file 0 comments Download
D ui/file_manager/file_manager/audio_player/assets/200/player_button_volume_active.png View Binary file 0 comments Download
D ui/file_manager/file_manager/audio_player/assets/200/player_timeline_base_center.png View Binary file 0 comments Download
D ui/file_manager/file_manager/audio_player/assets/200/player_timeline_base_left.png View Binary file 0 comments Download
D ui/file_manager/file_manager/audio_player/assets/200/player_timeline_base_right.png View Binary file 0 comments Download
D ui/file_manager/file_manager/audio_player/assets/200/player_timeline_handler.png View Binary file 0 comments Download
D ui/file_manager/file_manager/audio_player/assets/200/player_timeline_handler_pressed.png View Binary file 0 comments Download
D ui/file_manager/file_manager/audio_player/assets/200/player_timeline_played_center.png View Binary file 0 comments Download
D ui/file_manager/file_manager/audio_player/assets/200/player_timeline_played_left.png View Binary file 0 comments Download
D ui/file_manager/file_manager/audio_player/assets/200/player_timeline_played_right.png View Binary file 0 comments Download
D ui/file_manager/file_manager/audio_player/assets/200/player_volume_base_bottom.png View Binary file 0 comments Download
D ui/file_manager/file_manager/audio_player/assets/200/player_volume_base_center.png View Binary file 0 comments Download
D ui/file_manager/file_manager/audio_player/assets/200/player_volume_base_top.png View Binary file 0 comments Download
D ui/file_manager/file_manager/audio_player/assets/200/player_volume_level_bottom.png View Binary file 0 comments Download
D ui/file_manager/file_manager/audio_player/assets/200/player_volume_level_center.png View Binary file 0 comments Download
D ui/file_manager/file_manager/audio_player/assets/200/player_volume_level_top.png View Binary file 0 comments Download
D ui/file_manager/file_manager/audio_player/css/audio_player.css View 1 chunk +0 lines, -91 lines 0 comments Download
D ui/file_manager/file_manager/audio_player/elements/audio_player.css View 1 chunk +0 lines, -12 lines 0 comments Download
D ui/file_manager/file_manager/audio_player/elements/audio_player.js View 1 chunk +0 lines, -382 lines 0 comments Download
D ui/file_manager/file_manager/audio_player/elements/control_panel.css View 1 chunk +0 lines, -426 lines 0 comments Download
D ui/file_manager/file_manager/audio_player/elements/control_panel.js View 1 chunk +0 lines, -177 lines 0 comments Download
D ui/file_manager/file_manager/audio_player/elements/track_list.css View 1 chunk +0 lines, -76 lines 0 comments Download
D ui/file_manager/file_manager/audio_player/elements/track_list.js View 1 chunk +0 lines, -297 lines 0 comments Download
D ui/file_manager/file_manager/audio_player/elements/volume_controller.css View 1 chunk +0 lines, -52 lines 0 comments Download
D ui/file_manager/file_manager/audio_player/elements/volume_controller.js View 1 chunk +0 lines, -115 lines 0 comments Download
D ui/file_manager/file_manager/audio_player/icons/audio-player-128.png View Binary file 0 comments Download
D ui/file_manager/file_manager/audio_player/icons/audio-player-256.png View Binary file 0 comments Download
D ui/file_manager/file_manager/audio_player/icons/audio-player-32.png View Binary file 0 comments Download
D ui/file_manager/file_manager/audio_player/icons/audio-player-48.png View Binary file 0 comments Download
D ui/file_manager/file_manager/audio_player/icons/audio-player-64.png View Binary file 0 comments Download
D ui/file_manager/file_manager/audio_player/icons/audio-player-96.png View Binary file 0 comments Download
D ui/file_manager/file_manager/audio_player/icons/audio-player-favicon-16.png View Binary file 0 comments Download
D ui/file_manager/file_manager/audio_player/icons/audio-player-favicon-32.png View Binary file 0 comments Download
D ui/file_manager/file_manager/audio_player/js/audio_player.js View 1 chunk +0 lines, -429 lines 0 comments Download
D ui/file_manager/file_manager/audio_player/js/audio_player_model.js View 1 chunk +0 lines, -84 lines 0 comments Download
D ui/file_manager/file_manager/audio_player/js/audio_player_scripts.js View 1 chunk +0 lines, -46 lines 0 comments Download
M ui/file_manager/file_manager/background/js/background.js View 3 chunks +17 lines, -90 lines 0 comments Download
M ui/file_manager/file_manager/foreground/js/file_tasks.js View 1 chunk +0 lines, -19 lines 0 comments Download
M ui/file_manager/file_manager/manifest.json View 1 chunk +0 lines, -14 lines 0 comments Download
M ui/file_manager/file_manager_resources.grd View 1 3 chunks +14 lines, -5 lines 0 comments Download

Powered by Google App Engine
This is Rietveld 408576698