chrome/browser/chromeos/input_method/input_method_engine_unittest.cc - Issue 641243005: Support a private event - inputMethodPrivate.onCompositionBoundsChanged so that component IME exten…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/input_method/input_method_engine_unittest.cc

Issue 641243005: Support a private event - inputMethodPrivate.onCompositionBoundsChanged so that component IME exten… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/input_method/input_method_engine_interface.h ('k') | chrome/browser/chromeos/input_method/mock_input_method_engine.h » ('j') | chrome/browser/extensions/api/input_ime/input_ime_api.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/input_method/input_method_engine_unittest.cc

diff --git a/chrome/browser/chromeos/input_method/input_method_engine_unittest.cc b/chrome/browser/chromeos/input_method/input_method_engine_unittest.cc

index 0401f418304868b8655699a6b64e8a7885dc62de..377dd847c0819e1ac7426fca8a8a7eff3ebb81a0 100644

--- a/chrome/browser/chromeos/input_method/input_method_engine_unittest.cc

+++ b/chrome/browser/chromeos/input_method/input_method_engine_unittest.cc

@@ -97,6 +97,7 @@ class TestObserver : public InputMethodEngineInterface::Observer {

const std::string& text,

int cursor_pos,

int anchor_pos) override {}

+ virtual void OnCompositionBoundsChanged(const gfx::Rect& bounds) override {}

Yuki 2014/10/24 09:52:33 It would be great if we can have a test. Very very

Shu Chen 2014/10/24 15:38:06 Done.

virtual void OnReset(const std::string& engine_id) override {}

unsigned char GetCallsBitmapAndReset() {