Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(340)

Issue 641233004: Temporarily disable fast/events/key-events-in-input-button.html (Closed)

Created:
6 years, 2 months ago by robwu
Modified:
6 years, 1 month ago
Reviewers:
abarth-chromium
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Update expected result of fast/events/key-events-in-input-button.html and temporarily disable this test until https://codereview.chromium.org/649343002 has landed. BUG=423270 NOTRY=true TBR=abarth@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184762

Patch Set 1 #

Patch Set 2 : keypress event.keyIdentifier is only set for Enter #

Patch Set 3 : rebase origin/master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M LayoutTests/TestExpectations View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M LayoutTests/fast/events/key-events-in-input-button-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 24 (14 generated)
robwu
6 years, 2 months ago (2014-10-14 09:11:44 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/641233004/20001
6 years, 2 months ago (2014-10-17 11:22:51 UTC) #4
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 2 months ago (2014-10-17 11:22:53 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/641233004/20001
6 years, 2 months ago (2014-10-24 23:16:51 UTC) #10
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 2 months ago (2014-10-24 23:16:54 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/641233004/80001
6 years, 1 month ago (2014-10-28 11:04:53 UTC) #17
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 1 month ago (2014-10-28 11:04:58 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/641233004/80001
6 years, 1 month ago (2014-10-30 09:09:06 UTC) #21
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 1 month ago (2014-10-30 09:09:11 UTC) #23
robwu
6 years, 1 month ago (2014-10-31 23:57:59 UTC) #24
Message was sent while issue was closed.
Committed patchset #3 (id:80001) manually as 184762 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698