Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1361)

Unified Diff: cc/output/filter_operations.h

Issue 64123005: Update filter blending to match spec draft. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | cc/output/filter_operations.cc » ('j') | cc/output/filter_operations.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/output/filter_operations.h
diff --git a/cc/output/filter_operations.h b/cc/output/filter_operations.h
index 410a50d937605ac6ae1b2dbcfc1c836e488ac986..318089fc49db664f612ad2eae229d677749ebffb 100644
--- a/cc/output/filter_operations.h
+++ b/cc/output/filter_operations.h
@@ -63,14 +63,23 @@ class CC_EXPORT FilterOperations {
// it is treated as a sequence of the same length as the other sequence,
// where the filter at each position is a no-op filter of the same type
// as the filter in that position in the other sequence. Otherwise, if
- // both |from| and this are non-empty sequences but are either of different
- // lengths or if there is a type mismatch at some position, returns a copy
- // of this.
+ // both |from| and this are non-empty sequences but either contains a
+ // reference filter, are either of different lengths without a common prefix
ajuma 2013/11/11 18:39:41 The condition is stronger than "common prefix" (si
avallee 2013/11/12 20:18:09 SGTM
+ // or if there is a type mismatch at some position, returns a copy of this.
FilterOperations Blend(const FilterOperations& from, double progress) const;
+
danakj 2013/11/11 17:59:57 remove extra whitespace
avallee 2013/11/12 20:18:09 Done.
scoped_ptr<base::Value> AsValue() const;
private:
+ // Blend helper which blends operations of different sizes. If the shortest
+ // of |from| and this doesn't match the order and type of operations, returns
+ // this. Otherwise, blends the matching operations from the shorter list and
+ // blends the remaining filters from the longer list with their no-op
+ // equivalents.
+ FilterOperations BlendRaggedOperations(const FilterOperations& from,
+ double progress) const;
+
std::vector<FilterOperation> operations_;
};
« no previous file with comments | « no previous file | cc/output/filter_operations.cc » ('j') | cc/output/filter_operations.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698