Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(587)

Issue 641203004: Revert of Content Shell: Introduce LayoutTestBrowserContext. (Closed)

Created:
6 years, 2 months ago by apavlov
Modified:
6 years, 2 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, jochen+watch_chromium.org, mkwst+moarreviews-shell_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of Content Shell: Introduce LayoutTestBrowserContext. (patchset #2 id:20001 of https://codereview.chromium.org/637843003/) Reason for revert: Tentatively resulted in multiple layout test timeouts across the chromium.webkit waterfall. Original issue's description: > Content Shell: Introduce LayoutTestBrowserContext. > > This splits the DRT-specific parts of ShellBrowserContext out into a new > class that we'll only instantiate when the flag is set. > > BUG=420994 > > Committed: https://crrev.com/98ce5ad6bdd2cd058c21f19b997032f3b958cb73 > Cr-Commit-Position: refs/heads/master@{#299068} TBR=jochen@chromium.org,mkwst@chromium.org NOTREECHECKS=true NOTRY=true BUG=420994 Committed: https://crrev.com/297746b9c09c220f55f470cc02caaee9495ae61c Cr-Commit-Position: refs/heads/master@{#299077}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -117 lines) Patch
M content/content_shell.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M content/shell/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
D content/shell/browser/layout_test/layout_test_browser_context.h View 1 chunk +0 lines, -37 lines 0 comments Download
D content/shell/browser/layout_test/layout_test_browser_context.cc View 1 chunk +0 lines, -54 lines 0 comments Download
M content/shell/browser/shell_browser_context.h View 1 chunk +7 lines, -6 lines 0 comments Download
M content/shell/browser/shell_browser_context.cc View 4 chunks +13 lines, -6 lines 0 comments Download
M content/shell/browser/shell_browser_main_parts.cc View 2 chunks +3 lines, -10 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
apavlov
Created Revert of Content Shell: Introduce LayoutTestBrowserContext.
6 years, 2 months ago (2014-10-10 08:23:24 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/641203004/1
6 years, 2 months ago (2014-10-10 08:24:57 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-10 08:25:33 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/297746b9c09c220f55f470cc02caaee9495ae61c Cr-Commit-Position: refs/heads/master@{#299077}
6 years, 2 months ago (2014-10-10 08:26:21 UTC) #6
Mike West
6 years, 2 months ago (2014-10-10 10:47:04 UTC) #7
Message was sent while issue was closed.
LGTM. I've confirmed that this patch broke layout tests, and I'm working on a
replacement in https://codereview.chromium.org/641343002/. Thanks for the timely
revert, apavlov!

Powered by Google App Engine
This is Rietveld 408576698