Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1193)

Unified Diff: src/IceTranslator.h

Issue 641193002: Introduce the notion of function addresses in Subzero. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Patch Set: Fix nit in test. Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/IceTargetLoweringX8632.cpp ('k') | src/IceTranslator.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/IceTranslator.h
diff --git a/src/IceTranslator.h b/src/IceTranslator.h
index 8aeda94684f58e9079a38fe02b6ccc882d5a81f6..8134697e60fab24402289161ebc5be165e805627 100644
--- a/src/IceTranslator.h
+++ b/src/IceTranslator.h
@@ -25,16 +25,15 @@ namespace Ice {
class ClFlags;
class Cfg;
-class GlobalAddress;
+class VariableDeclaration;
class GlobalContext;
-// Base class for translating ICE to machine code.
-// Derived classes convert other intermediate representations down to ICE,
-// and then call the appropriate (inherited) methods to convert ICE into
-// machine instructions.
+// Base class for translating ICE to machine code. Derived classes convert
+// other intermediate representations down to ICE, and then call the appropriate
+// (inherited) methods to convert ICE into machine instructions.
class Translator {
public:
- typedef std::vector<Ice::GlobalAddress *> GlobalAddressList;
+ typedef std::vector<VariableDeclaration *> VariableDeclarationListType;
Translator(GlobalContext *Ctx, const ClFlags &Flags)
: Ctx(Ctx), Flags(Flags), ErrorStatus(0) {}
@@ -54,8 +53,9 @@ public:
/// Emits the constant pool.
void emitConstants();
- /// Lowers the given list of global addresses to target.
- void lowerGlobals(const GlobalAddressList &GlobalAddresses);
+ /// Lowers the given list of global addresses to target. Generates
+ /// list of corresponding variable declarations.
+ void lowerGlobals(const VariableDeclarationListType &VariableDeclarations);
/// Creates a name using the given prefix and corresponding index.
std::string createUnnamedName(const IceString &Prefix, SizeT Index);
@@ -66,15 +66,6 @@ public:
bool checkIfUnnamedNameSafe(const IceString &Name, const char *Kind,
const IceString &Prefix, Ostream &Stream);
- // Walks module and generates names for unnamed globals using prefix
- // getFlags().DefaultGlobalPrefix, if the prefix is non-empty.
- void nameUnnamedGlobalAddresses(llvm::Module *Mod);
-
- // Walks module and generates names for unnamed functions using
- // prefix getFlags().DefaultFunctionPrefix, if the prefix is
- // non-empty.
- void nameUnnamedFunctions(llvm::Module *Mod);
-
protected:
GlobalContext *Ctx;
const ClFlags &Flags;
« no previous file with comments | « src/IceTargetLoweringX8632.cpp ('k') | src/IceTranslator.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698