Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Unified Diff: src/IceTranslator.h

Issue 641193002: Introduce the notion of function addresses in Subzero. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Patch Set: Clean up code and fix nits. Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/IceTranslator.h
diff --git a/src/IceTranslator.h b/src/IceTranslator.h
index 8aeda94684f58e9079a38fe02b6ccc882d5a81f6..02a9001e7e777d81e6dacf2d5c44efe3827b9803 100644
--- a/src/IceTranslator.h
+++ b/src/IceTranslator.h
@@ -25,7 +25,7 @@ namespace Ice {
class ClFlags;
class Cfg;
-class GlobalAddress;
+class GlobalVariable;
class GlobalContext;
// Base class for translating ICE to machine code.
@@ -34,7 +34,7 @@ class GlobalContext;
// machine instructions.
class Translator {
public:
- typedef std::vector<Ice::GlobalAddress *> GlobalAddressList;
+ typedef std::vector<Ice::GlobalVariable *> GlobalVariableListType;
Translator(GlobalContext *Ctx, const ClFlags &Flags)
: Ctx(Ctx), Flags(Flags), ErrorStatus(0) {}
@@ -55,7 +55,7 @@ public:
void emitConstants();
/// Lowers the given list of global addresses to target.
- void lowerGlobals(const GlobalAddressList &GlobalAddresses);
+ void lowerGlobals(const GlobalVariableListType &GlobalVariables);
/// Creates a name using the given prefix and corresponding index.
std::string createUnnamedName(const IceString &Prefix, SizeT Index);
@@ -68,7 +68,7 @@ public:
// Walks module and generates names for unnamed globals using prefix
// getFlags().DefaultGlobalPrefix, if the prefix is non-empty.
- void nameUnnamedGlobalAddresses(llvm::Module *Mod);
+ void nameUnnamedGlobalVariables(llvm::Module *Mod);
// Walks module and generates names for unnamed functions using
// prefix getFlags().DefaultFunctionPrefix, if the prefix is

Powered by Google App Engine
This is Rietveld 408576698