Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Unified Diff: src/IceTranslator.cpp

Issue 641193002: Introduce the notion of function addresses in Subzero. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Patch Set: Clean up code and fix nits. Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/IceTranslator.cpp
diff --git a/src/IceTranslator.cpp b/src/IceTranslator.cpp
index e86d60a304d6155751ce836693851590270a46d4..2976cd4473d732c9207f0e0d31a47f9a09ab9f6c 100644
--- a/src/IceTranslator.cpp
+++ b/src/IceTranslator.cpp
@@ -54,7 +54,7 @@ bool Translator::checkIfUnnamedNameSafe(const IceString &Name, const char *Kind,
return false;
}
-void Translator::nameUnnamedGlobalAddresses(llvm::Module *Mod) {
+void Translator::nameUnnamedGlobalVariables(llvm::Module *Mod) {
const IceString &GlobalPrefix = Flags.DefaultGlobalPrefix;
if (GlobalPrefix.empty())
return;
@@ -110,12 +110,12 @@ void Translator::emitConstants() {
Func->getTarget()->emitConstants();
}
-void Translator::lowerGlobals(const GlobalAddressList &GlobalAddresses) {
+void Translator::lowerGlobals(const GlobalVariableListType &GlobalVariables) {
llvm::OwningPtr<Ice::TargetGlobalInitLowering> GlobalLowering(
Ice::TargetGlobalInitLowering::createLowering(Ctx->getTargetArch(), Ctx));
bool DisableTranslation = Ctx->getFlags().DisableTranslation;
- for (const Ice::GlobalAddress *Addr : GlobalAddresses) {
- GlobalLowering->lower(*Addr, DisableTranslation);
+ for (const Ice::GlobalVariable *Global : GlobalVariables) {
+ GlobalLowering->lower(*Global, DisableTranslation);
}
GlobalLowering.reset();
}

Powered by Google App Engine
This is Rietveld 408576698