Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Unified Diff: src/IceTargetLowering.h

Issue 641193002: Introduce the notion of function addresses in Subzero. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Patch Set: Clean up code and fix nits. Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/IceTargetLowering.h
diff --git a/src/IceTargetLowering.h b/src/IceTargetLowering.h
index f116cf31ea685546402ea759fee5172e29822570..a24e180b9e3cb9475e5599f77b1631cbb32c2239 100644
--- a/src/IceTargetLowering.h
+++ b/src/IceTargetLowering.h
@@ -27,7 +27,7 @@ namespace Ice {
typedef uint8_t AsmCodeByte;
class Assembler;
-class GlobalAddress;
+class GlobalVariable;
// LoweringContext makes it easy to iterate through non-deleted
// instructions in a node, and insert new (lowered) instructions at
@@ -249,7 +249,7 @@ public:
GlobalContext *Ctx);
virtual ~TargetGlobalInitLowering();
- virtual void lower(const GlobalAddress &Addr, bool DisableTranslation) = 0;
+ virtual void lower(const GlobalVariable &Vbl, bool DisableTranslation) = 0;
jvoung (off chromium) 2014/10/10 01:47:28 nit: How about "Var" instead of "Vbl"?
Karl 2014/10/10 20:17:30 Done.
protected:
TargetGlobalInitLowering(GlobalContext *Ctx) : Ctx(Ctx) {}

Powered by Google App Engine
This is Rietveld 408576698