Introduce the notion of function addresses in Subzero.

tests_lit/reader_tests/globalinit.pnacl.ll

 ; Test of global initializers.

[jvoung (off chromium), 2014/10/10 23:01:16]

There was also a copy of this in llvm2ice_tests. Do we need both? Do you mind if
I remove one of them?

[Karl, 2014/10/13 17:43:02]

I agree that these two tests are doing the same thing, but they shouldn't. This
should only be testing parsing. The other should only be testing translation.
Fixing this file to only test parsing.

[jvoung (off chromium), 2014/10/13 21:25:43]

Thanks!

I think that the " .att_syntax" etc, parts below which are x86-specific can be
removed too then.

Undecided about what .section .data parts, but I guess we can revisit that when
doing direct-to-object.

[Karl, 2014/10/13 22:01:32]

Removed the translated code.

 
 ; Check that we generate proper global initializers.
 ; RUN: %p2i -i %s --args -verbose inst | FileCheck %s
 
 ; Check that what we generate is valid assembly
 ; RUN: %p2i -i %s --args -verbose none \
 ; RUN:     | llvm-mc -triple=i686-none-nacl -x86-asm-syntax=intel -filetype=obj
 
 ; Check that we don't generate errors
 ; RUN: %p2i -i %s --args -verbose none | FileCheck --check-prefix=ERRORS %s
 
 @PrimitiveInit = internal global [4 x i8] c"\1B\00\00\00", align 4
-; CHECK: .type PrimitiveInit,@object
+; CHECK: @PrimitiveInit = internal global [4 x i8] c"\1B\00\00\00", align 4
+; CHECK-NEXT: .type PrimitiveInit,@object
 ; CHECK-NEXT: .section .data,"aw",@progbits
 ; CHECK-NEXT: .align 4
 ; CHECK-NEXT: PrimitiveInit:
 ; CHECK-NEXT: .byte
 ; CHECK: .size PrimitiveInit, 4
 
 @PrimitiveInitConst = internal constant [4 x i8] c"\0D\00\00\00", align 4
-; CHECK: .type PrimitiveInitConst,@object
+; CHECK-NEXT: @PrimitiveInitConst = internal constant [4 x i8] c"\0D\00\00\00", align 4
+; CHECK-NEXT: .type PrimitiveInitConst,@object
 ; CHECK-NEXT: .section .rodata,"a",@progbits
 ; CHECK-NEXT: .align 4
 ; CHECK-NEXT: PrimitiveInitConst:
 ; CHECK-NEXT: .byte
 ; CHECK: .size PrimitiveInitConst, 4
 
 @ArrayInit = internal global [20 x i8] c"\0A\00\00\00\14\00\00\00\1E\00\00\00(\00\00\002\00\00\00", align 4
-; CHECK: .type ArrayInit,@object
+; CHECK-NEXT: @ArrayInit = internal global [20 x i8] c"\0A\00\00\00\14\00\00\00\1E\00\00\00(\00\00\002\00\00\00", align 4
+; CHECK-NEXT: .type ArrayInit,@object
 ; CHECK-NEXT: .section .data,"aw",@progbits
 ; CHECK-NEXT: .align 4
 ; CHECK-NEXT: ArrayInit:
 ; CHECK-NEXT: .byte
 ; CHECK: .size ArrayInit, 20
 
 @ArrayInitPartial = internal global [40 x i8] c"<\00\00\00F\00\00\00P\00\00\00Z\00\00\00d\00\00\00\00\00\00\00\00\00\00\00\00\00\00\00\00\00\00\00\00\00\00\00", align 4
-; CHECK: .type ArrayInitPartial,@object
+; CHECK-NEXT: @ArrayInitPartial = internal global [40 x i8] c"<\00\00\00F\00\00\00P\00\00\00Z\00\00\00d\00\00\00\00\00\00\00\00\00\00\00\00\00\00\00\00\00\00\00\00\00\00\00", align 4
+; CHECK-NEXT: .type ArrayInitPartial,@object
 ; CHECK-NEXT: .section .data,"aw",@progbits
 ; CHECK-NEXT: .align 4
 ; CHECK-NEXT: ArrayInitPartial:
 ; CHECK-NEXT: .byte
 ; CHECK: .size ArrayInitPartial, 40
 
 @PrimitiveInitStatic = internal global [4 x i8] zeroinitializer, align 4
-; CHECK: .type PrimitiveInitStatic,@object
+; CHECK-NEXT: @PrimitiveInitStatic = internal global [4 x i8] zeroinitializer, align 4
+; CHECK-NEXT: .type PrimitiveInitStatic,@object
 ; CHECK-NEXT: .local PrimitiveInitStatic
 ; CHECK-NEXT: .comm PrimitiveInitStatic,4,4
 
 @PrimitiveUninit = internal global [4 x i8] zeroinitializer, align 4
-; CHECK: .type PrimitiveUninit,@object
+; CHECK-NEXT: @PrimitiveUninit = internal global [4 x i8] zeroinitializer, align 4
+; CHECK-NEXT: .type PrimitiveUninit,@object
 ; CHECK-NEXT: .local PrimitiveUninit
 ; CHECK-NEXT: .comm PrimitiveUninit,4,4
 
 @ArrayUninit = internal global [20 x i8] zeroinitializer, align 4
-; CHECK: .type ArrayUninit,@object
+; CHECK-NEXT: @ArrayUninit = internal global [20 x i8] zeroinitializer, align 4
+; CHECK-NEXT: .type ArrayUninit,@object
 ; CHECK-NEXT: .local ArrayUninit
 ; CHECK-NEXT: .comm ArrayUninit,20,4
 
 @ArrayUninitConstDouble = internal constant [200 x i8] zeroinitializer, align 8
-; CHECK: .type ArrayUninitConstDouble,@object
+; CHECK-NEXT: @ArrayUninitConstDouble = internal constant [200 x i8] zeroinitializer, align 8
+; CHECK-NEXT: .type ArrayUninitConstDouble,@object
 ; CHECK-NEXT: .section .rodata,"a",@progbits
 ; CHECK-NEXT: .align 8
 ; CHECK-NEXT: ArrayUninitConstDouble:
 ; CHECK-NEXT: .zero 200
 ; CHECK-NEXT: .size ArrayUninitConstDouble, 200
 
 @ArrayUninitConstInt = internal constant [20 x i8] zeroinitializer, align 4
-; CHECK: .type ArrayUninitConstInt,@object
-; CHECK: .section .rodata,"a",@progbits
+; CHECK-NEXT: @ArrayUninitConstInt = internal constant [20 x i8] zeroinitializer, align 4
+; CHECK-NEXT: .type ArrayUninitConstInt,@object
+; CHECK-NEXT: .section .rodata,"a",@progbits
 ; CHECK-NEXT: .align 4
 ; CHECK-NEXT: ArrayUninitConstInt:
 ; CHECK-NEXT: .zero 20
 ; CHECK-NEXT: .size ArrayUninitConstInt, 20
 
 @__init_array_start = internal constant [0 x i8] zeroinitializer, align 4
+; CHECK-NEXT: @__init_array_start = internal constant [0 x i8] zeroinitializer, align 4
+
 @__fini_array_start = internal constant [0 x i8] zeroinitializer, align 4
+; CHECK: @__fini_array_start = internal constant [0 x i8] zeroinitializer, align 4
+
 @__tls_template_start = internal constant [0 x i8] zeroinitializer, align 8
+; CHECK: @__tls_template_start = internal constant [0 x i8] zeroinitializer, align 8
+
 @__tls_template_alignment = internal constant [4 x i8] c"\01\00\00\00", align 4
+; CHECK: @__tls_template_alignment = internal constant [4 x i8] c"\01\00\00\00", align 4
 
 define internal i32 @main(i32 %argc, i32 %argv) {
 entry:
   %expanded1 = ptrtoint [4 x i8]* @PrimitiveInit to i32
   call void @use(i32 %expanded1)
   %expanded3 = ptrtoint [4 x i8]* @PrimitiveInitConst to i32
   call void @use(i32 %expanded3)
   %expanded5 = ptrtoint [4 x i8]* @PrimitiveInitStatic to i32
   call void @use(i32 %expanded5)
   %expanded7 = ptrtoint [4 x i8]* @PrimitiveUninit to i32
@@ skipping 36 matching lines @@
   ret i32 0
 }
 
 define internal i32 @nacl_tp_tls_offset(i32 %size) {
 entry:
   %result = sub i32 0, %size
   ret i32 %result
 }
 
 ; ERRORS-NOT: ICE translation error