Introduce the notion of function addresses in Subzero.

src/IceTargetLowering.h

 //===- subzero/src/IceTargetLowering.h - Lowering interface -----*- C++ -*-===//
 //
 //                        The Subzero Code Generator
 //
 // This file is distributed under the University of Illinois Open Source
 // License. See LICENSE.TXT for details.
 //
 //===----------------------------------------------------------------------===//
 //
 // This file declares the TargetLowering and LoweringContext
 // classes.  TargetLowering is an abstract class used to drive the
 // translation/lowering process.  LoweringContext maintains a
 // context for lowering each instruction, offering conveniences such
 // as iterating over non-deleted instructions.
 //
 //===----------------------------------------------------------------------===//
 
 #ifndef SUBZERO_SRC_ICETARGETLOWERING_H
 #define SUBZERO_SRC_ICETARGETLOWERING_H
 
 #include "IceDefs.h"
 #include "IceInst.h" // for the names of the Inst subtypes
 #include "IceTypes.h"
 
 namespace Ice {
 
 typedef uint8_t AsmCodeByte;
 
 class Assembler;
-class GlobalAddress;
+class GlobalVariable;
 
 // LoweringContext makes it easy to iterate through non-deleted
 // instructions in a node, and insert new (lowered) instructions at
 // the current point.  Along with the instruction list container and
 // associated iterators, it holds the current node, which is needed
 // when inserting new instructions in order to track whether variables
 // are used as single-block or multi-block.
 class LoweringContext {
 public:
   LoweringContext() : Node(NULL) {}
@@ skipping 201 matching lines @@
 
 // TargetGlobalInitLowering is used for "lowering" global
 // initializers.  It is separated out from TargetLowering because it
 // does not require a Cfg.
 class TargetGlobalInitLowering {
 public:
   static TargetGlobalInitLowering *createLowering(TargetArch Target,
                                                   GlobalContext *Ctx);
   virtual ~TargetGlobalInitLowering();
 
-  virtual void lower(const GlobalAddress &Addr, bool DisableTranslation) = 0;
+  virtual void lower(const GlobalVariable &Vbl, bool DisableTranslation) = 0;

[jvoung (off chromium), 2014/10/10 01:47:28]

nit: How about "Var" instead of "Vbl"?

[Karl, 2014/10/10 20:17:30]

Done.

 
 protected:
   TargetGlobalInitLowering(GlobalContext *Ctx) : Ctx(Ctx) {}
   GlobalContext *Ctx;
 
 private:
   TargetGlobalInitLowering(const TargetGlobalInitLowering &) = delete;
   TargetGlobalInitLowering &operator=(const TargetGlobalInitLowering &) =
       delete;
 };
 
 } // end of namespace Ice
 
 #endif // SUBZERO_SRC_ICETARGETLOWERING_H