Introduce the notion of function addresses in Subzero.

src/IceConverter.h

 //===- subzero/src/IceConverter.h - Converts LLVM to ICE --------*- C++ -*-===//
 //
 //                        The Subzero Code Generator
 //
 // This file is distributed under the University of Illinois Open Source
 // License. See LICENSE.TXT for details.
 //
 //===----------------------------------------------------------------------===//
 //
 // This file declares the LLVM to ICE converter.
 //
 //===----------------------------------------------------------------------===//
 
 #ifndef SUBZERO_SRC_ICECONVERTER_H
 #define SUBZERO_SRC_ICECONVERTER_H
 
+#include "IceDefs.h"
 #include "IceTranslator.h"
 
 namespace llvm {
+class GlobalValue;
 class Module;
 }
 
 namespace Ice {
 
 class Converter : public Translator {
 public:
+  typedef std::map<const llvm::GlobalValue *, GlobalAddress *>
+      GlobalAddressMapType;
   Converter(llvm::Module *Mod, GlobalContext *Ctx, const Ice::ClFlags &Flags)
       : Translator(Ctx, Flags), Mod(Mod) {}
 
+  ~Converter() {}

[jvoung (off chromium), 2014/10/10 01:47:28]

override?

[Karl, 2014/10/10 20:17:30]

Why. A translator doesn't have any virtual methods. Are you suggesting that any
class that can have derived classes should have a virtual destructor?

+
   /// Converts the LLVM Module to ICE. Sets exit status to false if successful,
   /// true otherwise.
   void convertToIce();
 
+  llvm::Module *getModule() { return Mod; }

[jvoung (off chromium), 2014/10/10 01:47:28]

method is "const"?

[Karl, 2014/10/10 20:17:30]

Done.

+
+  // Returns the global address associated with the corresponding global value
+  // V.
+  // Returns nullptr if no such global address.
+  GlobalAddress *getGlobalAddress(const llvm::GlobalValue *V);
+
 private:
   llvm::Module *Mod;
+  GlobalAddressMapType GlobalAddressMap;
   // Converts functions to ICE, and then machine code.
   void convertFunctions();
 
   // Converts globals to ICE, and then machine code.
   void convertGlobals(llvm::Module *Mod);
 
+  // Installs global addresses into GlobalAddressMap.
+  void installGlobalAddresses(llvm::Module *Mod);
+
   Converter(const Converter &) = delete;
   Converter &operator=(const Converter &) = delete;
 };
 
 } // end of namespace ICE.
 
 #endif // SUBZERO_SRC_ICECONVERTER_H