src/compiler/x64/instruction-selector-x64.cc - Issue 641153003: [turbofan]IA: ChangeFloat32ToFloat64 supports mem operand

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/compiler/x64/instruction-selector-x64.cc

Issue 641153003: [turbofan]IA: ChangeFloat32ToFloat64 supports mem operand (Closed) Base URL: https://github.com/v8/v8.git@bleeding_edge

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/compiler/x64/instruction-selector-x64.cc

diff --git a/src/compiler/x64/instruction-selector-x64.cc b/src/compiler/x64/instruction-selector-x64.cc

index 7f9e40afe2c4a2209b929b7d71440968b84576e1..d3fd8f2d742bea2200413a7e9ff05b7bab1984f4 100644

--- a/src/compiler/x64/instruction-selector-x64.cc

+++ b/src/compiler/x64/instruction-selector-x64.cc

@@ -608,8 +608,7 @@ void InstructionSelector::VisitUint64Mod(Node* node) {

void InstructionSelector::VisitChangeFloat32ToFloat64(Node* node) {

X64OperandGenerator g(this);

- // TODO(turbofan): X64 SSE conversions should take an operand.

- Emit(kSSECvtss2sd, g.DefineAsRegister(node), g.UseRegister(node->InputAt(0)));

+ Emit(kSSECvtss2sd, g.DefineAsRegister(node), g.Use(node->InputAt(0)));

}

« no previous file with comments | « src/compiler/x64/code-generator-x64.cc ('k') | src/ia32/assembler-ia32.h » ('j') | no next file with comments »