Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(811)

Issue 641123002: Cleanup LoginUtils. (Closed)

Created:
6 years, 2 months ago by Nikita (slow)
Modified:
6 years, 2 months ago
Reviewers:
Alexander Alekseev
CC:
chromium-reviews, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Cleanup LoginUtils. Theses methods don't need to be public. BUG=TBD Committed: https://crrev.com/edd46df85666b8b76bba7134cb29315faf706af5 Cr-Commit-Position: refs/heads/master@{#299096}

Patch Set 1 #

Patch Set 2 : return flags method #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -20 lines) Patch
M chrome/browser/chromeos/login/fake_login_utils.h View 1 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/fake_login_utils.cc View 1 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/login/login_utils.h View 1 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/login/login_utils.cc View 1 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/test_login_utils.h View 1 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/test_login_utils.cc View 1 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
Nikita (slow)
6 years, 2 months ago (2014-10-09 15:36:06 UTC) #2
Alexander Alekseev
lgtm
6 years, 2 months ago (2014-10-09 18:31:44 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/641123002/1
6 years, 2 months ago (2014-10-09 18:34:01 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_swarming/builds/22510)
6 years, 2 months ago (2014-10-09 19:30:53 UTC) #7
Nikita (slow)
LoginUtils::RestartToApplyPerSessionFlagsIfNeed() has to be public though because it is called from ProfileImpl.
6 years, 2 months ago (2014-10-10 10:58:05 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/641123002/180001
6 years, 2 months ago (2014-10-10 11:28:24 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:180001)
6 years, 2 months ago (2014-10-10 12:10:20 UTC) #11
commit-bot: I haz the power
6 years, 2 months ago (2014-10-10 12:11:05 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/edd46df85666b8b76bba7134cb29315faf706af5
Cr-Commit-Position: refs/heads/master@{#299096}

Powered by Google App Engine
This is Rietveld 408576698