Issue 641063002: fix ios build

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 641063002: fix ios build (Closed)

Created:
6 years, 2 months ago by caryclark

Modified:
6 years, 2 months ago

Reviewers:
tfarina

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Project:
skia

Visibility:
Public.

More Reviews

Description

fix ios build NOTREECHECKS=true NOTRY=true TBR= Committed: https://skia.googlesource.com/skia/+/ff9fc4e4c9f54e675a3ce1a0124debca33b46e1b

Patch Set 1 #

Total comments: 1

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -0 lines)			Patch
	M	tests/StrokerTest.cpp	View		1 chunk	+2 lines, -0 lines	1 comment	Download

Messages

Total messages: 5 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/641063002/1

6 years, 2 months ago (2014-10-09 13:13:40 UTC) #2

commit-bot: I haz the power

Committed patchset #1 (id:1) as ff9fc4e4c9f54e675a3ce1a0124debca33b46e1b

6 years, 2 months ago (2014-10-09 13:13:53 UTC) #3

tfarina

6 years, 2 months ago (2014-10-09 13:21:54 UTC) #5

Message was sent while issue was closed.

lgtm, looks like, though see comment below.

https://codereview.chromium.org/641063002/diff/1/tests/StrokerTest.cpp
File tests/StrokerTest.cpp (right):

https://codereview.chromium.org/641063002/diff/1/tests/StrokerTest.cpp#newcode11
tests/StrokerTest.cpp:11: #ifndef SK_BUILD_FOR_IOS
if you use !definded, then it is easier for someone to come in later and add
'||| defined(...)'.

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages