Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(414)

Issue 641053003: IA2 role is not correct for input type button and checkbox with aria role menu as parent (Closed)

Created:
6 years, 2 months ago by shreeramk
Modified:
6 years, 2 months ago
Reviewers:
dmazzoni, Mike West
CC:
blink-reviews, dmazzoni, aboxhall
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

IA2 role is not correct for input type button and checkbox with aria role menu as parent This is continuation of this CL https://codereview.chromium.org/629173002/ Changes were not added in AXRenderObject.cpp BUG=169574 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183515

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M Source/core/accessibility/AXRenderObject.cpp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
shreeramk
Please review. Thanks
6 years, 2 months ago (2014-10-09 16:31:45 UTC) #2
dmazzoni
lgtm
6 years, 2 months ago (2014-10-10 05:33:55 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/641053003/1
6 years, 2 months ago (2014-10-10 05:34:59 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-10-10 06:18:55 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 183515

Powered by Google App Engine
This is Rietveld 408576698