Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(615)

Issue 641043003: Add ActivityLog tests for chrome.tabs.executeScript() (Closed)

Created:
6 years, 2 months ago by Devlin
Modified:
6 years, 2 months ago
Reviewers:
felt
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, felt, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Add ActivityLog tests for chrome.tabs.executeScript() BUG=357204 Committed: https://crrev.com/4ee236b9c60e54ae563e7e07e0334715954a83bc Cr-Commit-Position: refs/heads/master@{#299404}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+90 lines, -7 lines) Patch
M chrome/browser/extensions/activity_log/ad_injection_browsertest.cc View 1 chunk +52 lines, -0 lines 0 comments Download
A chrome/test/data/extensions/activity_log/execute_script_ad_injection/background.js View 1 chunk +34 lines, -0 lines 0 comments Download
A + chrome/test/data/extensions/activity_log/execute_script_ad_injection/manifest.json View 1 chunk +4 lines, -7 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Devlin
Adrienne, please take a look when you can.
6 years, 2 months ago (2014-10-09 19:00:31 UTC) #2
Devlin
On 2014/10/09 19:00:31, Devlin wrote: > Adrienne, please take a look when you can. Friendly ...
6 years, 2 months ago (2014-10-13 22:14:50 UTC) #3
felt
lgtm
6 years, 2 months ago (2014-10-13 23:05:59 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/641043003/1
6 years, 2 months ago (2014-10-13 23:08:12 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-14 00:26:33 UTC) #7
commit-bot: I haz the power
6 years, 2 months ago (2014-10-14 00:27:51 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4ee236b9c60e54ae563e7e07e0334715954a83bc
Cr-Commit-Position: refs/heads/master@{#299404}

Powered by Google App Engine
This is Rietveld 408576698