Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1137)

Unified Diff: src/store-buffer.cc

Issue 6410119: Fix the logic of when to disable the store buffer. (Closed) Base URL: http://v8.googlecode.com/svn/branches/experimental/gc/
Patch Set: Created 9 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/store-buffer.cc
===================================================================
--- src/store-buffer.cc (revision 6662)
+++ src/store-buffer.cc (working copy)
@@ -358,19 +358,18 @@
if (!during_gc_) {
SortUniq();
}
- if (old_limit_ - old_top_ < old_limit_ - old_top_) {
+ if (old_limit_ - old_top_ > old_top_ - old_start_) {
return;
}
// TODO(gc): Set an interrupt to do a GC on the next back edge.
// TODO(gc): Allocate the rest of new space to force a GC on the next
// allocation.
- if (old_limit_ - old_top_ < kStoreBufferSize) {
- // After compression we don't even have enough space for the next
- // compression to be guaranteed to succeed.
- // TODO(gc): Set a flag to scan all of memory.
- Counters::store_buffer_overflows.Increment();
- set_store_buffer_mode(kStoreBufferDisabled);
- }
+ // TODO(gc): Make the disabling of the store buffer dependendent on
+ // those two measures failing:
+ // After compression not enough space was freed up in the store buffer. We
+ // might as well stop sorting and trying to eliminate duplicates.
+ Counters::store_buffer_overflows.Increment();
+ set_store_buffer_mode(kStoreBufferDisabled);
}
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698