Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(478)

Issue 6410039: Update AudioMixerAlsa to not use PrefMember. (Closed)

Created:
9 years, 10 months ago by stevenjb
Modified:
9 years, 7 months ago
Reviewers:
DaveMoore, davejcool
CC:
chromium-reviews, davemoore+watch_chromium.org
Visibility:
Public.

Description

Update AudioMixerAlsa to not use PrefMember. AudioMixerAlsa is a Singleton and PrefMember relies on the associated PrefService still existing in its Destructor, which can not be gauranteed for a Singleton. BUG=chromium-os:11407 TEST=suite_Smoke Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=73518

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -13 lines) Patch
M chrome/browser/chromeos/audio_mixer_alsa.h View 3 chunks +3 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/audio_mixer_alsa.cc View 5 chunks +8 lines, -9 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
stevenjb
This is causing suite_Smoke to fail due to crashes on shutdown, so a quick review ...
9 years, 10 months ago (2011-02-02 20:38:17 UTC) #1
davejcool
On 2011/02/02 20:38:17, Steven Bennetts wrote: > This is causing suite_Smoke to fail due to ...
9 years, 10 months ago (2011-02-02 21:42:13 UTC) #2
stevenjb
9 years, 10 months ago (2011-02-02 21:45:13 UTC) #3
On 2011/02/02 21:42:13, davejcool wrote:
> On 2011/02/02 20:38:17, Steven Bennetts wrote:
> > This is causing suite_Smoke to fail due to crashes on shutdown, so a quick
> > review would be appreciated, thanks!
> 
> LGTM.
> 
> It still performs as expected.  Thanks!

Great. I am going to push this before the tests complete since it is blocking
cros builds, but I will keep an eye on the test results.

Powered by Google App Engine
This is Rietveld 408576698