Issue 6410039: Update AudioMixerAlsa to not use PrefMember.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6410039: Update AudioMixerAlsa to not use PrefMember. (Closed)

Created:
9 years, 10 months ago by stevenjb

Modified:
9 years, 7 months ago

Reviewers:
DaveMoore, davejcool

CC:
chromium-reviews, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Update AudioMixerAlsa to not use PrefMember. AudioMixerAlsa is a Singleton and PrefMember relies on the associated PrefService still existing in its Destructor, which can not be gauranteed for a Singleton. BUG=chromium-os:11407 TEST=suite_Smoke Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=73518

Patch Set 1 #

Created: 9 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -13 lines)			Patch
	M	chrome/browser/chromeos/audio_mixer_alsa.h	View		3 chunks	+3 lines, -4 lines	0 comments	Download
	M	chrome/browser/chromeos/audio_mixer_alsa.cc	View		5 chunks	+8 lines, -9 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

stevenjb

This is causing suite_Smoke to fail due to crashes on shutdown, so a quick review ...

9 years, 10 months ago (2011-02-02 20:38:17 UTC) #1

davejcool

On 2011/02/02 20:38:17, Steven Bennetts wrote: > This is causing suite_Smoke to fail due to ...

9 years, 10 months ago (2011-02-02 21:42:13 UTC) #2

stevenjb

9 years, 10 months ago (2011-02-02 21:45:13 UTC) #3

On 2011/02/02 21:42:13, davejcool wrote:
> On 2011/02/02 20:38:17, Steven Bennetts wrote:
> > This is causing suite_Smoke to fail due to crashes on shutdown, so a quick
> > review would be appreciated, thanks!
> 
> LGTM.
> 
> It still performs as expected.  Thanks!

Great. I am going to push this before the tests complete since it is blocking
cros builds, but I will keep an eye on the test results.

Expand Messages | Collapse Messages