Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 640953004: DevTools: Fix elements panel search in shadow host. (Closed)

Created:
6 years, 2 months ago by vsevik
Modified:
6 years, 2 months ago
Reviewers:
pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Project:
blink
Visibility:
Public.

Description

DevTools: Fix elements panel search in shadow host. R=pfeldman BUG=426815 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184360

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -2 lines) Patch
M LayoutTests/inspector/elements/elements-panel-search.html View 2 chunks +7 lines, -2 lines 0 comments Download
M LayoutTests/inspector/elements/elements-panel-search-expected.txt View 1 chunk +3 lines, -0 lines 0 comments Download
M Source/core/inspector/InspectorDOMAgent.cpp View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
vsevik
PTAL
6 years, 2 months ago (2014-10-24 12:54:57 UTC) #1
pfeldman
lgtm
6 years, 2 months ago (2014-10-24 12:55:42 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/640953004/1
6 years, 2 months ago (2014-10-24 12:56:58 UTC) #4
commit-bot: I haz the power
6 years, 2 months ago (2014-10-24 14:33:03 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 184360

Powered by Google App Engine
This is Rietveld 408576698