Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(955)

Issue 64093003: Use a fixed random seed per default. (Closed)

Created:
7 years, 1 month ago by Sven Panne
Modified:
7 years, 1 month ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Visibility:
Public.

Description

Use a fixed random seed per default. To get back the old behavior, use "make randomseed=0 ...". BUG=v8:1880, v8:2885 R=jkummerow@chromium.org Committed: http://code.google.com/p/v8/source/detail?r=17555

Patch Set 1 #

Total comments: 1

Patch Set 2 : Nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -0 lines) Patch
M Makefile View 1 chunk +4 lines, -0 lines 0 comments Download
M tools/gyp/v8.gyp View 1 2 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Sven Panne
7 years, 1 month ago (2013-11-07 10:08:18 UTC) #1
Jakob Kummerow
LGTM with nit. https://codereview.chromium.org/64093003/diff/1/tools/gyp/v8.gyp File tools/gyp/v8.gyp (right): https://codereview.chromium.org/64093003/diff/1/tools/gyp/v8.gyp#newcode164 tools/gyp/v8.gyp:164: ] nit: trailing comma for consistency
7 years, 1 month ago (2013-11-07 10:40:17 UTC) #2
Sven Panne
7 years, 1 month ago (2013-11-07 12:01:34 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r17555 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698