Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Issue 640903002: change newly added OVERRIDE to override in components/ (Closed)

Created:
6 years, 2 months ago by Mostyn Bramley-Moore
Modified:
6 years, 2 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

change newly added OVERRIDE to override in components/ BUG=417463 Committed: https://crrev.com/8473eb697ebe66eb321aff002247e8a310a3db00 Cr-Commit-Position: refs/heads/master@{#298870}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -16 lines) Patch
M components/proximity_auth/cryptauth/cryptauth_api_call_flow.h View 1 chunk +7 lines, -7 lines 0 comments Download
M components/proximity_auth/cryptauth/cryptauth_api_call_flow_unittest.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M components/signin/ios/browser/oauth2_token_service_observer_bridge.h View 1 chunk +5 lines, -5 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
Mostyn Bramley-Moore
@Ilya: can you please check components/proximity_auth/ ? @Roger: can you please check components/signin/ ?
6 years, 2 months ago (2014-10-08 21:50:23 UTC) #2
Ilya Sherman
LGTM, thanks.
6 years, 2 months ago (2014-10-08 21:51:07 UTC) #3
Roger Tawa OOO till Jul 10th
lgtm
6 years, 2 months ago (2014-10-09 13:19:41 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/640903002/1
6 years, 2 months ago (2014-10-09 13:31:12 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1) as 98849d283051a38d55efa4089f01d2f1fd7f9164
6 years, 2 months ago (2014-10-09 13:54:14 UTC) #9
commit-bot: I haz the power
6 years, 2 months ago (2014-10-09 13:55:51 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8473eb697ebe66eb321aff002247e8a310a3db00
Cr-Commit-Position: refs/heads/master@{#298870}

Powered by Google App Engine
This is Rietveld 408576698