Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(163)

Issue 640873002: cc: Move RequiresHighResToDraw from tree to lthi. (Closed)

Created:
6 years, 2 months ago by vmpstr
Modified:
6 years, 2 months ago
Reviewers:
danakj, enne (OOO)
CC:
chromium-reviews, cc-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

cc: Move RequiresHighResToDraw from tree to lthi. This patch moves RequiresHighResToDraw setting (with setters) to LTHI. The reason for this change is that we have situations in which we need to access this property from the pending tree as well (when deciding whether tiles are required for activation). Additionally, most of the fiddling with the setting comes from LTHI anyway, so it makes sense for the property to live there. R=danakj, enne Committed: https://crrev.com/61ed94a131d32778521dd373646535157fbcb27e Cr-Commit-Position: refs/heads/master@{#298787}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -46 lines) Patch
M cc/layers/picture_layer_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/layers/picture_layer_impl_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/trees/layer_tree_host_impl.h View 2 chunks +6 lines, -0 lines 0 comments Download
M cc/trees/layer_tree_host_impl.cc View 6 chunks +7 lines, -6 lines 0 comments Download
M cc/trees/layer_tree_host_impl_unittest.cc View 5 chunks +19 lines, -19 lines 0 comments Download
M cc/trees/layer_tree_host_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M cc/trees/layer_tree_impl.h View 3 chunks +1 line, -5 lines 0 comments Download
M cc/trees/layer_tree_impl.cc View 3 chunks +2 lines, -11 lines 0 comments Download
M cc/trees/thread_proxy.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
vmpstr
PTAL
6 years, 2 months ago (2014-10-08 20:32:20 UTC) #1
enne (OOO)
lgtm
6 years, 2 months ago (2014-10-08 20:34:42 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/640873002/1
6 years, 2 months ago (2014-10-08 21:22:30 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/640873002/1
6 years, 2 months ago (2014-10-08 23:11:57 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1) as fab6b2a0faefe7da0e7c0e357b39be90f43f3602
6 years, 2 months ago (2014-10-09 04:49:43 UTC) #8
commit-bot: I haz the power
6 years, 2 months ago (2014-10-09 04:50:40 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/61ed94a131d32778521dd373646535157fbcb27e
Cr-Commit-Position: refs/heads/master@{#298787}

Powered by Google App Engine
This is Rietveld 408576698